You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/07/01 13:51:27 UTC
Review Request 70985: Added `suppressOffers(roles)` to V0 Java
bindings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
Added `suppressOffers(roles)` to V0 Java bindings.
Diffs
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a21aca23cbef27b3c54bf1ae5834cbb457608130
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4
src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f
Diff: https://reviews.apache.org/r/70985/diff/1/
Testing
-------
Called this method from a modified example framework (WIP).
Thanks,
Andrei Sekretenko
Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java
bindings.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216305
-----------------------------------------------------------
Bad review!
Reviews applied: [70985, 70984, 70983, 70945, 70944, 70943, 70947, 70942, 70941, 70982, 70895, 70897, 70894]
Error:
2019-07-02 11:01:16 URL:https://reviews.apache.org/r/70941/diff/raw/ [3294/3294] -> "70941.patch" [1]
error: patch failed: include/mesos/scheduler.hpp:293
error: include/mesos/scheduler.hpp: patch does not apply
error: patch failed: src/sched/sched.cpp:1436
error: src/sched/sched.cpp: patch does not apply
- Mesos Reviewbot
On July 1, 2019, 1:51 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 1:51 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `suppressOffers(roles)` to V0 Java bindings.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a21aca23cbef27b3c54bf1ae5834cbb457608130
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4
> src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f
>
>
> Diff: https://reviews.apache.org/r/70985/diff/1/
>
>
> Testing
> -------
>
> Called this method from a modified example framework (WIP).
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java
bindings.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
> On July 3, 2019, 10:32 p.m., Benjamin Mahler wrote:
> > src/java/src/org/apache/mesos/MesosSchedulerDriver.java
> > Lines 402-404 (patched)
> > <https://reviews.apache.org/r/70985/diff/2/?file=2153512#file2153512line402>
> >
> > Why the extra level of indirection? Why not just make this native like the others?
Somehow I was mislead into thinking that native methods do not support overloading.
Figured out how to do that and got rid of this indirection.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216364
-----------------------------------------------------------
On July 4, 2019, 3:19 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> -----------------------------------------------------------
>
> (Updated July 4, 2019, 3:19 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `suppressOffers(roles)` to V0 Java bindings.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
> src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
>
>
> Diff: https://reviews.apache.org/r/70985/diff/3/
>
>
> Testing
> -------
>
> Called this method from a modified example framework (WIP).
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java
bindings.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216364
-----------------------------------------------------------
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
Lines 402-404 (patched)
<https://reviews.apache.org/r/70985/#comment303566>
Why the extra level of indirection? Why not just make this native like the others?
- Benjamin Mahler
On July 3, 2019, 5:06 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> -----------------------------------------------------------
>
> (Updated July 3, 2019, 5:06 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `suppressOffers(roles)` to V0 Java bindings.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
> src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
>
>
> Diff: https://reviews.apache.org/r/70985/diff/2/
>
>
> Testing
> -------
>
> Called this method from a modified example framework (WIP).
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java
bindings.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216389
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70894, 70897, 70895, 70982, 70941, 70942, 70947, 70985]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 4, 2019, 3:19 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> -----------------------------------------------------------
>
> (Updated July 4, 2019, 3:19 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `suppressOffers(roles)` to V0 Java bindings.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
> src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
>
>
> Diff: https://reviews.apache.org/r/70985/diff/3/
>
>
> Testing
> -------
>
> Called this method from a modified example framework (WIP).
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java
bindings.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216392
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 4, 2019, 3:19 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> -----------------------------------------------------------
>
> (Updated July 4, 2019, 3:19 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `suppressOffers(roles)` to V0 Java bindings.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
> src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
>
>
> Diff: https://reviews.apache.org/r/70985/diff/3/
>
>
> Testing
> -------
>
> Called this method from a modified example framework (WIP).
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java
bindings.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/
-----------------------------------------------------------
(Updated July 4, 2019, 3:19 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
Added `suppressOffers(roles)` to V0 Java bindings.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
Diff: https://reviews.apache.org/r/70985/diff/3/
Changes: https://reviews.apache.org/r/70985/diff/2-3/
Testing
-------
Called this method from a modified example framework (WIP).
Thanks,
Andrei Sekretenko
Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java
bindings.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/
-----------------------------------------------------------
(Updated July 3, 2019, 5:06 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Made suppressing an empty collection of roles a no-op.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
Added `suppressOffers(roles)` to V0 Java bindings.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
Diff: https://reviews.apache.org/r/70985/diff/2/
Changes: https://reviews.apache.org/r/70985/diff/1-2/
Testing
-------
Called this method from a modified example framework (WIP).
Thanks,
Andrei Sekretenko