You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:44:34 UTC
[GitHub] [pulsar] huangdx0726 opened a new pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
huangdx0726 opened a new pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042
Fixes #6957
### Motivation
Add debezium Sqlserver source
### Modifications
Add debezium Sqlserver source
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-728638732
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-729459757
@huangdx0726 I think the integration test you added failed. Can you check the following error?
```
05:52:23.218 [tc-okhttp-stream-869783420:org.apache.pulsar.tests.integration.utils.DockerUtils$2@257] ERROR org.apache.pulsar.tests.integration.utils.DockerUtils - DOCKER.exec(PulsarFunctionsProcessTest-xzzxp:cat debezium-sqlserver-init/inventory.sql | docker exec -i debezium-sqlserver-example bash -c '/opt/mssql-tools/bin/sqlcmd -U sa -P $SA_PASSWORD'): completed with non zero return code: 126
stdout: OCI runtime exec failed: exec failed: container_linux.go:370: starting container process caused: exec: "cat debezium-sqlserver-init/inventory.sql | docker exec -i debezium-sqlserver-example bash -c '/opt/mssql-tools/bin/sqlcmd -U sa -P $SA_PASSWORD'": stat cat debezium-sqlserver-init/inventory.sql | docker exec -i debezium-sqlserver-example bash -c '/opt/mssql-tools/bin/sqlcmd -U sa -P $SA_PASSWORD': no such file or directory: unknown
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-730996818
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-636473891
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-638589296
move to 2.7.0 first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-728707744
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-634494191
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-730144063
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-731012200
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-652786802
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-729628229
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-728676732
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-845967447
@huangdx0726 Could you please resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-648527614
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-729460100
Remove this from 2.7.0 release first. If you can fix the integration test before the release, we can include it. Otherwise, let's include it for 2.8.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-721480565
@huangdx0726 Could you please take a look at the failed CI tests? looks related to the maven poms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-726383015
@huangdx0726 Can you rebase it to the latest master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-637435818
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-636331326
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-730182936
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-634440868
@huangdx0726 Would you please help take a look at the failed CI tests? Looks related to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-730825632
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-729667331
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-678872258
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-730085306
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-726533812
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] huangdx0726 commented on pull request #7042: [Issue 6957][pulsar-io-debezium] Support CDC Connector for SqlServer
Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on pull request #7042:
URL: https://github.com/apache/pulsar/pull/7042#issuecomment-730055312
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org