You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/01 22:57:00 UTC

[jira] [Commented] (KAFKA-6684) Support casting values with bytes schema to string

    [ https://issues.apache.org/jira/browse/KAFKA-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460261#comment-16460261 ] 

ASF GitHub Bot commented on KAFKA-6684:
---------------------------------------

bbejeck opened a new pull request #4950: KAFKA-6684: Call shutdown on all GlobalStreamThread after all StreamThreads have stopped
URL: https://github.com/apache/kafka/pull/4950
 
 
   Moved the shutdown of `GlobalStreamThread` to after all `StreamThread` instances have stopped. 
   
   There can be a race condition where shut down is called on a `StreamThread` then shut down is called on a GlobalStreamThread, but if StreamThread is delayed in shutting down, and the GlobalStreamThread can shutdown first.
   If the StreamThread tries to access a GlobalStateStore before closing the user can get an exception stating  "..Store xxx is currently closed "
   
   
   
   Tested by running all current streams tests.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support casting values with bytes schema to string 
> ---------------------------------------------------
>
>                 Key: KAFKA-6684
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6684
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>            Reporter: Amit Sela
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> Casting from BYTES is not supported, which means that casting LogicalTypes is not supported.
> This proposes to allow casting anything to a string, kind of like Java's {{toString()}}, such that if the object is actually a LogicalType it can be "serialized" as string instead of bytes+schema.
>  
> {noformat}
> Examples:
> BigDecimal will cast to the string representation of the number.
> Timestamp will cast to the string representation of the timestamp, or maybe UTC yyyymmddTHH:MM:SS.f format?
> {noformat}
>  
> Worst case, bytes are "casted" to whatever the {{toString()}} returns - its up to the user to know the data.
> This would help when using a JSON sink, or anything that's not Avro.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)