[GitHub] matthiasblaesing commented on issue #799: [NETBEANS-1074] Module Review web.jsf12

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #799: [NETBEANS-1074] Module Review web.jsf12
URL: https://github.com/apache/incubator-netbeans/pull/799#issuecomment-419140019
 
 
   Ok - I had another look at it. This is my result:
   https://github.com/matthiasblaesing/incubator-netbeans/commit/55b390687a94003eb85d170453b1461ea4f5d41a
   
   That commit:
   - restores the original file name of API jar to `jsf-api.jar`
   - add `binary-origin` to the `class-path-extension` elements
   - add separate RI download was added to `web.jsf12ri`
   - the additional libraries (commons*) are removed, as `jdeps` does not report any dependencies on `org.apache` packages (apart from Tomcat integration). I assume they were necessary in the past
   - the shaded apache beanutils, collections and digester packages are not present in the 1.2_05 version of the RI, so their package export is adjusted accordingly
   - the maven dependencies are modified to match the referenced libraries
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists