You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/01 22:45:03 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #8495: [datasource editor] Only one click target for edit action

graceguo-supercat opened a new pull request #8495: [datasource editor] Only one click target for edit action
URL: https://github.com/apache/incubator-superset/pull/8495
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Some of our users didn't know how to find all options for edit datasource, since they didn't realize the **_datasource name_** and **_caret_** are different label buttons.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:**
   <img width="457" alt="Screen Shot 2019-11-01 at 3 16 35 PM" src="https://user-images.githubusercontent.com/27990562/68059688-9f67b000-fcba-11e9-9be3-c282ac6ab9da.png">
   
   **After:**
   <img width="1002" alt="Screen Shot 2019-11-01 at 3 41 24 PM" src="https://user-images.githubusercontent.com/27990562/68060584-34b87380-fcbe-11e9-9f8c-2fb848e3a691.png">
   
   
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org