[GitHub] spark pull request: Expose aplication ID in ApplicationStart event...

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1218#discussion_r15823358
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1531,18 +1532,6 @@ object SparkContext extends Logging {
                 throw new SparkException("YARN mode not available ?", e)
               }
             }
    -        val backend = try {
    -          val clazz =
    -            Class.forName("org.apache.spark.scheduler.cluster.YarnClusterSchedulerBackend")
    -          val cons = clazz.getConstructor(classOf[TaskSchedulerImpl], classOf[SparkContext])
    -          cons.newInstance(scheduler, sc).asInstanceOf[CoarseGrainedSchedulerBackend]
    -        } catch {
    -          case e: Exception => {
    -            throw new SparkException("YARN mode not available ?", e)
    -          }
    -        }
    -        scheduler.initialize(backend)
    -        scheduler
    --- End diff --
    
    I haven't looked at this in detail yet, but it seems a bit odd to me to move this particular one down into the YarnClusterScheduler but the rest define backend and initialize them here.  I would think it would be easier to read having it here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org