You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "balesh2 (GitHub)" <gi...@apache.org> on 2018/11/29 23:35:10 UTC
[GitHub] [geode] balesh2 opened pull request #2923: GEODE-6612: Gfsh
should respond to SIGINT
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] balesh2 commented on issue #2923: GEODE-6612: Gfsh
should respond to SIGINT
Posted by "balesh2 (GitHub)" <gi...@apache.org>.
That issue no longer exists because I have seen locator processes outlive gfsh. But there is another issue with this implementation, which is that ctrl-c with text in the prompt kills gfsh instead of just getting rid of the text like a normal terminal does, which would be extremely frustrating behavior as a user.
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] balesh2 commented on issue #2923: GEODE-6112: Gfsh
should respond to SIGINT
Posted by "balesh2 (GitHub)" <gi...@apache.org>.
Closing this until it is ready for PR.
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on issue #2923: GEODE-6612: Gfsh
should respond to SIGINT
Posted by "metatype (GitHub)" <gi...@apache.org>.
@kirklund Do you know why SIGINT was being tossed?
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #2923: GEODE-6612: Gfsh
should respond to SIGINT
Posted by "kirklund (GitHub)" <gi...@apache.org>.
I think SpringShell which GFSH extends has or had a bug (possibly caused by the version of JLine it uses) which caused CTRL-C of GFSH to also terminate any processes that GFSH had launched. I'm not sure if this problem still exists or if it was specific to an OS or version of an OS. Jens may know more about it -- I think he was working on the signal handling mechanism in GFSH.
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] balesh2 closed pull request #2923: GEODE-6112: Gfsh
should respond to SIGINT
Posted by "balesh2 (GitHub)" <gi...@apache.org>.
[ pull request closed by balesh2 ]
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] balesh2 commented on issue #2923: GEODE-6612: Gfsh
should respond to SIGINT
Posted by "balesh2 (GitHub)" <gi...@apache.org>.
I do think there should be tests for this, I just wanted to see if I would break anything else by doing this before putting too much time into unit tests for it
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #2923: GEODE-6612: Gfsh
should respond to SIGINT
Posted by "kirklund (GitHub)" <gi...@apache.org>.
I think SpringShell which GFSH extends has or had a bug (possibly caused by the version of JLine it uses) which caused CTRL-C of GFSH to also terminate any processes that GFSH had launched. I'm not sure if this problem still exists. Jens may know more about it -- I think he was working on the signal handling mechanism in GFSH.
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org