You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2016/11/25 09:04:24 UTC

[10/20] camel git commit: Tone down logging noise

Tone down logging noise


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/8cb830b5
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/8cb830b5
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/8cb830b5

Branch: refs/heads/master
Commit: 8cb830b58f0372b458f61f22378e2447e473e089
Parents: 2c7bded
Author: Claus Ibsen <da...@apache.org>
Authored: Fri Nov 25 09:59:21 2016 +0100
Committer: Claus Ibsen <da...@apache.org>
Committed: Fri Nov 25 09:59:21 2016 +0100

----------------------------------------------------------------------
 .../camel/component/dropbox/core/DropboxAPIFacade.java       | 8 ++++----
 .../integration/consumer/DropboxScheduledPollConsumer.java   | 4 ++--
 .../consumer/DropboxScheduledPollGetConsumer.java            | 5 +++--
 .../consumer/DropboxScheduledPollSearchConsumer.java         | 4 +++-
 .../dropbox/integration/producer/DropboxDelProducer.java     | 2 +-
 .../dropbox/integration/producer/DropboxGetProducer.java     | 2 +-
 .../dropbox/integration/producer/DropboxMoveProducer.java    | 2 +-
 .../dropbox/integration/producer/DropboxProducer.java        | 4 ++--
 .../dropbox/integration/producer/DropboxPutProducer.java     | 4 +++-
 9 files changed, 20 insertions(+), 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/core/DropboxAPIFacade.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/core/DropboxAPIFacade.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/core/DropboxAPIFacade.java
index a4bf887..a979c86 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/core/DropboxAPIFacade.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/core/DropboxAPIFacade.java
@@ -109,7 +109,7 @@ public final class DropboxAPIFacade {
             }
             return result;
         } else {       //verify uploading of a list of files inside a dir
-            LOG.info("uploading a dir...");
+            LOG.debug("Uploading a dir...");
             //check if dropbox folder exists
             if (entry != null && !entry.isFolder()) {
                 throw new DropboxException(dropboxPath + " exists on dropbox and is not a folder!");
@@ -135,7 +135,7 @@ public final class DropboxAPIFacade {
                 String remainingPath = absPath.substring(indexRemainingPath);
                 dropboxPath = dropboxPath + remainingPath;
                 try {
-                    LOG.info("uploading:" + fileLocalPath + "," + dropboxPath);
+                    LOG.debug("Uploading: {},{}", fileLocalPath, dropboxPath);
                     DbxEntry.File uploadedFile = putSingleFile(file, dropboxPath, mode);
                     if (uploadedFile == null) {
                         resultMap.put(dropboxPath, DropboxResultCode.KO);
@@ -179,7 +179,7 @@ public final class DropboxAPIFacade {
     public DropboxSearchResult search(String remotePath, String query) throws DropboxException {
         DbxEntry.WithChildren listing;
         if (query == null) {
-            LOG.info("search no query");
+            LOG.debug("Search no query");
             try {
                 listing = client.getMetadataWithChildren(remotePath);
                 return new DropboxSearchResult(listing.children);
@@ -187,7 +187,7 @@ public final class DropboxAPIFacade {
                 throw new DropboxException(remotePath + " does not exist or can't obtain metadata");
             }
         } else {
-            LOG.info("search by query:" + query);
+            LOG.debug("Search by query: {}", query);
             try {
                 List<DbxEntry> entries = client.searchFileAndFolderNames(remotePath, query);
                 return new DropboxSearchResult(entries);

http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollConsumer.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollConsumer.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollConsumer.java
index 8c5bcd6..9ad8a51 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollConsumer.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollConsumer.java
@@ -49,7 +49,7 @@ public abstract class DropboxScheduledPollConsumer extends ScheduledPollConsumer
             //create dropbox client
             configuration.createClient();
 
-            LOG.info("consumer dropbox client created");
+            LOG.debug("Consumer DropBox client created");
         }
 
         super.doStart();
@@ -65,7 +65,7 @@ public abstract class DropboxScheduledPollConsumer extends ScheduledPollConsumer
         if (configuration.getClient() == null) {
             configuration.setClient(null);
 
-            LOG.info("consumer dropbox client deleted");
+            LOG.debug("Consumer DropBox client deleted");
         }
         super.doStop();
     }

http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollGetConsumer.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollGetConsumer.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollGetConsumer.java
index bb954ce..406ee6f 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollGetConsumer.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollGetConsumer.java
@@ -58,8 +58,9 @@ public class DropboxScheduledPollGetConsumer extends DropboxScheduledPollConsume
             exchange.getIn().setBody(map);
         }
 
-
-        LOG.info("consumer --> downloaded: " + result.toString());
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Downloaded: {}", result.toString());
+        }
 
         try {
             // send message to next processor in the route

http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollSearchConsumer.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollSearchConsumer.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollSearchConsumer.java
index 6d63136..aa3bdd9 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollSearchConsumer.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/consumer/DropboxScheduledPollSearchConsumer.java
@@ -50,7 +50,9 @@ public class DropboxScheduledPollSearchConsumer extends DropboxScheduledPollCons
         exchange.getIn().setHeader(DropboxResultHeader.FOUND_FILES.name(), fileExtracted.toString());
         exchange.getIn().setBody(result.getFound());
 
-        LOG.info("consumer --> downloaded: " + result.toString());
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Downloaded: {}", result.toString());
+        }
 
         try {
             // send message to next processor in the route

http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxDelProducer.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxDelProducer.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxDelProducer.java
index b579b64..41ceb8e 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxDelProducer.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxDelProducer.java
@@ -35,7 +35,7 @@ public class DropboxDelProducer extends DropboxProducer {
             .del(configuration.getRemotePath());
         exchange.getIn().setHeader(DropboxResultHeader.DELETED_PATH.name(), result.getEntry());
         exchange.getIn().setBody(result.getEntry());
-        log.info("Deleted: " + configuration.getRemotePath());
+        log.debug("Deleted: {}", configuration.getRemotePath());
     }
 
 }

http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxGetProducer.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxGetProducer.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxGetProducer.java
index c344cbd..3427c1d 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxGetProducer.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxGetProducer.java
@@ -53,7 +53,7 @@ public class DropboxGetProducer extends DropboxProducer {
             exchange.getIn().setHeader(DropboxResultHeader.DOWNLOADED_FILES.name(), pathsExtracted.toString());
             exchange.getIn().setBody(map);
         }
-        LOG.info("producer --> downloaded: " + result.toString());
+        LOG.debug("Downloaded: {}", result.toString());
     }
 
 }

http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxMoveProducer.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxMoveProducer.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxMoveProducer.java
index bdab9a5..a1e46a2 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxMoveProducer.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxMoveProducer.java
@@ -37,7 +37,7 @@ public class DropboxMoveProducer extends DropboxProducer {
         exchange.getIn().setHeader(DropboxResultHeader.MOVED_PATH.name(), result.getOldPath());
         exchange.getIn().setBody(result.getNewPath());
 
-        log.info("Moved from " + configuration.getRemotePath() + " to " + configuration.getNewRemotePath());
+        log.debug("Moved from {} to {}", configuration.getRemotePath(), configuration.getNewRemotePath());
     }
 
 }

http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxProducer.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxProducer.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxProducer.java
index 1ac15b3..b4b901b 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxProducer.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxProducer.java
@@ -41,7 +41,7 @@ public abstract class DropboxProducer extends DefaultProducer {
             //create dropbox client
             configuration.createClient();
 
-            LOG.info("producer dropbox client created");
+            LOG.debug("Producer DropBox client created");
         }
 
         super.doStart();
@@ -52,7 +52,7 @@ public abstract class DropboxProducer extends DefaultProducer {
         if (configuration.getClient() == null) {
             configuration.setClient(null);
 
-            LOG.info("producer dropbox client deleted");
+            LOG.debug("Producer DropBox client deleted");
         }
         super.doStop();
     }

http://git-wip-us.apache.org/repos/asf/camel/blob/8cb830b5/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxPutProducer.java
----------------------------------------------------------------------
diff --git a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxPutProducer.java b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxPutProducer.java
index b79ab5d..0bbe6d1 100755
--- a/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxPutProducer.java
+++ b/components/camel-dropbox/src/main/java/org/apache/camel/component/dropbox/integration/producer/DropboxPutProducer.java
@@ -57,7 +57,9 @@ public class DropboxPutProducer extends DropboxProducer {
             exchange.getIn().setBody(map);
         }
 
-        LOG.info("Uploaded: " + result.toString());
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Uploaded: {}", result.toString());
+        }
     }
 
 }