You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/02/06 15:17:42 UTC
[commons-io] branch master updated: IOCase.isCaseSensitive(IOCase) result is backward (#325)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
The following commit(s) were added to refs/heads/master by this push:
new 498ed66 IOCase.isCaseSensitive(IOCase) result is backward (#325)
498ed66 is described below
commit 498ed661d01f174ef9d6a7730db90aa9b6fe720a
Author: David Huang <hu...@gmail.com>
AuthorDate: Sun Feb 6 23:17:40 2022 +0800
IOCase.isCaseSensitive(IOCase) result is backward (#325)
* Handle static method isCaseSensitive of class IOCase.
* Update RegexFileFilter.java
Change the order of import statements, which the IDE automatically changes.
* Add a test of static method isCaseSensitive in class IOCaseTest.
Co-authored-by: huangxiaowei <hu...@newland.com.cn>
---
src/main/java/org/apache/commons/io/IOCase.java | 2 +-
src/main/java/org/apache/commons/io/filefilter/RegexFileFilter.java | 2 +-
src/test/java/org/apache/commons/io/IOCaseTest.java | 6 ++++++
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/commons/io/IOCase.java b/src/main/java/org/apache/commons/io/IOCase.java
index 201d5f3..6e93fd0 100644
--- a/src/main/java/org/apache/commons/io/IOCase.java
+++ b/src/main/java/org/apache/commons/io/IOCase.java
@@ -91,7 +91,7 @@ public enum IOCase {
* @since 2.10.0
*/
public static boolean isCaseSensitive(final IOCase ioCase) {
- return ioCase != null && !ioCase.isCaseSensitive();
+ return ioCase != null && ioCase.isCaseSensitive();
}
/**
diff --git a/src/main/java/org/apache/commons/io/filefilter/RegexFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/RegexFileFilter.java
index 91ffbd6..946a8e0 100644
--- a/src/main/java/org/apache/commons/io/filefilter/RegexFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/RegexFileFilter.java
@@ -89,7 +89,7 @@ public class RegexFileFilter extends AbstractFileFilter implements Serializable
* @return Pattern compilation flags.
*/
private static int toFlags(final IOCase ioCase) {
- return IOCase.isCaseSensitive(ioCase) ? Pattern.CASE_INSENSITIVE : 0;
+ return IOCase.isCaseSensitive(ioCase) ? 0 : Pattern.CASE_INSENSITIVE;
}
/** The regular expression pattern that will be used to match file names. */
diff --git a/src/test/java/org/apache/commons/io/IOCaseTest.java b/src/test/java/org/apache/commons/io/IOCaseTest.java
index ebf9b60..a3e3aed 100644
--- a/src/test/java/org/apache/commons/io/IOCaseTest.java
+++ b/src/test/java/org/apache/commons/io/IOCaseTest.java
@@ -301,4 +301,10 @@ public class IOCaseTest {
assertEquals("System", IOCase.SYSTEM.toString());
}
+ @Test
+ public void test_isCaseSensitive_static() {
+ assertTrue(IOCase.isCaseSensitive(IOCase.SENSITIVE));
+ assertFalse(IOCase.isCaseSensitive(IOCase.INSENSITIVE));
+ assertEquals(!WINDOWS, IOCase.isCaseSensitive(IOCase.SYSTEM));
+ }
}