You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2022/03/09 13:59:29 UTC

[VOTE] Release Apache Tomcat 10.1.0-M12

The proposed Apache Tomcat 10.1.0-M12 release is now available for
voting.

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
without changes. Java EE applications designed for Tomcat 9 and earlier 
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
will automatically convert them to Jakarta EE and copy them to the 
webapps directory.

The notable changes compared to 10.1.0-M11 are:

- Fix a potential thread-safety issue that could cause HTTP/1.1 request
   processing to pause, and potentially timeout, waiting for additional
   data when the full request has been received.

- Fix a regression introduced with 65757 bugfix which better identified
   non request threads but which introduced a similar problem when user
   code was doing sequential operations in a single thread.

- When resolving methods in EL expressions that use beans and/or static
   fields, ensure that any custom type conversion is considered when
   identifying the method to call.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1360

The tag is:
https://github.com/apache/tomcat/tree/10.1.0-M12
d08498a3cefa7206bad791acf019455794f865ea


The proposed 10.1.0-M12 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 10.1.0-M12

Posted by Mark Thomas <ma...@apache.org>.
On 09/03/2022 13:59, Mark Thomas wrote:

<snip/>

> The proposed 10.1.0-M12 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M12 (alpha)

Unit tests pass for NIO and NIO2 on Linux, MacOS and Windows.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 10.1.0-M12

Posted by Igal Sapir <is...@apache.org>.
Mark,

On Sun, Mar 13, 2022 at 10:00 AM Mark Thomas <ma...@apache.org> wrote:

> Works for me. CI systems (Gump, BuidlBot) also look OK.
>
> Maybe something related to the build environment?
>

Thanks!  I see the problem, and it also affects other versions, e.g. 9.0.x.

For each major version I have a git tree, and in that directory I have a
setting for the output directory, e.g. for 9.0.x I have
  tomcat.output=/workspace/build/tomcat/9.0.x

The manifest files are created in the correct directory:
  build-manifests:
      [mkdir] Created dir: /workspace/build/tomcat/9.0.x/manifests
       [copy] Copying 21 files to /workspace/build/tomcat/9.0.x/manifests

But are then "read" from the wrong place and fail because there is no such
directory:
      [bnd] 2 ERRORS
      [bnd]  Input file does not exist:
../../output/manifests/default.license
      [bnd]  Input file does not exist:
../../output/manifests/default.notice
      [bnd]
/workspace/src/tomcat/9.0.x/res/bnd/annotations-api.jar.tmp.bnd: bnd failed

I will try to find where that happens and patch it.

Igal



>
> Mark
>
>
> On 12/03/2022 19:45, Igal Sapir wrote:
> > On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas <ma...@apache.org> wrote:
> >
> >> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> >> voting.
> >>
> >> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> >> without changes. Java EE applications designed for Tomcat 9 and earlier
> >> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> >> will automatically convert them to Jakarta EE and copy them to the
> >> webapps directory.
> >>
> >> The notable changes compared to 10.1.0-M11 are:
> >>
> >> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
> >>     processing to pause, and potentially timeout, waiting for additional
> >>     data when the full request has been received.
> >>
> >> - Fix a regression introduced with 65757 bugfix which better identified
> >>     non request threads but which introduced a similar problem when user
> >>     code was doing sequential operations in a single thread.
> >>
> >> - When resolving methods in EL expressions that use beans and/or static
> >>     fields, ensure that any custom type conversion is considered when
> >>     identifying the method to call.
> >>
> >> For full details, see the changelog:
> >> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
> >>
> >> It can be obtained from:
> >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
> >>
> >> The Maven staging repo is:
> >> https://repository.apache.org/content/repositories/orgapachetomcat-1360
> >>
> >> The tag is:
> >> https://github.com/apache/tomcat/tree/10.1.0-M12
> >> d08498a3cefa7206bad791acf019455794f865ea
> >>
> >>
> >> The proposed 10.1.0-M12 release is:
> >> [ ] Broken - do not release
> >> [ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)
> >>
> >
> > Was there a change in dependencies?  I get an error while trying to run
> > `ant clean test` using Java 11.0.14 on Ubuntu 20.04:
> >
> > package:
> >        [jar] Building jar:
> > /workspace/build/tomcat/main/build/lib/annotations-api.jar
> >
> > add-osgi:
> >       [echo] add-osgi
> > /workspace/build/tomcat/main/build/lib/annotations-api.jar true
> >        [bnd] [main] WARN aQute.bnd.plugin.jpms.JPMSModuleInfoPlugin -
> Using
> > module name 'jakarta.annotation' for: Jar:annotations-api
> >        [bnd] 2 ERRORS
> >        [bnd]  Input file does not exist:
> > ../../output/manifests/default.license
> >        [bnd]  Input file does not exist:
> > ../../output/manifests/default.notice
> >        [bnd]
> /workspace/src/tomcat/main/res/bnd/annotations-api.jar.tmp.bnd:
> > bnd failed
> >        [bnd] at
> > aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:231)
> >        [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:117)
> >        [bnd] at
> > org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
> >        [bnd] at
> jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown
> > Source)
> >        [bnd] at
> >
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >        [bnd] at
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> >        [bnd] at
> >
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
> >        [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
> >        ...
> > BUILD FAILED
> > /workspace/src/tomcat/main/build.xml:1036: The following error occurred
> > while executing this line:
> > /workspace/src/tomcat/main/build.xml:3798: The following error occurred
> > while executing this line:
> > /workspace/src/tomcat/main/build.xml:3820: Failed to build jar file:
> >
> >
> > Igal
> >
> >
> >
> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.1.0-M12

Posted by Mark Thomas <ma...@apache.org>.
Works for me. CI systems (Gump, BuidlBot) also look OK.

Maybe something related to the build environment?

Mark


On 12/03/2022 19:45, Igal Sapir wrote:
> On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas <ma...@apache.org> wrote:
> 
>> The proposed Apache Tomcat 10.1.0-M12 release is now available for
>> voting.
>>
>> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
>> without changes. Java EE applications designed for Tomcat 9 and earlier
>> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
>> will automatically convert them to Jakarta EE and copy them to the
>> webapps directory.
>>
>> The notable changes compared to 10.1.0-M11 are:
>>
>> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>>     processing to pause, and potentially timeout, waiting for additional
>>     data when the full request has been received.
>>
>> - Fix a regression introduced with 65757 bugfix which better identified
>>     non request threads but which introduced a similar problem when user
>>     code was doing sequential operations in a single thread.
>>
>> - When resolving methods in EL expressions that use beans and/or static
>>     fields, ensure that any custom type conversion is considered when
>>     identifying the method to call.
>>
>> For full details, see the changelog:
>> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
>>
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1360
>>
>> The tag is:
>> https://github.com/apache/tomcat/tree/10.1.0-M12
>> d08498a3cefa7206bad791acf019455794f865ea
>>
>>
>> The proposed 10.1.0-M12 release is:
>> [ ] Broken - do not release
>> [ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)
>>
> 
> Was there a change in dependencies?  I get an error while trying to run
> `ant clean test` using Java 11.0.14 on Ubuntu 20.04:
> 
> package:
>        [jar] Building jar:
> /workspace/build/tomcat/main/build/lib/annotations-api.jar
> 
> add-osgi:
>       [echo] add-osgi
> /workspace/build/tomcat/main/build/lib/annotations-api.jar true
>        [bnd] [main] WARN aQute.bnd.plugin.jpms.JPMSModuleInfoPlugin - Using
> module name 'jakarta.annotation' for: Jar:annotations-api
>        [bnd] 2 ERRORS
>        [bnd]  Input file does not exist:
> ../../output/manifests/default.license
>        [bnd]  Input file does not exist:
> ../../output/manifests/default.notice
>        [bnd] /workspace/src/tomcat/main/res/bnd/annotations-api.jar.tmp.bnd:
> bnd failed
>        [bnd] at
> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:231)
>        [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:117)
>        [bnd] at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>        [bnd] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown
> Source)
>        [bnd] at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>        [bnd] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>        [bnd] at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>        [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>        ...
> BUILD FAILED
> /workspace/src/tomcat/main/build.xml:1036: The following error occurred
> while executing this line:
> /workspace/src/tomcat/main/build.xml:3798: The following error occurred
> while executing this line:
> /workspace/src/tomcat/main/build.xml:3820: Failed to build jar file:
> 
> 
> Igal
> 
> 
> 
> 
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 10.1.0-M12

Posted by Igal Sapir <is...@apache.org>.
On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas <ma...@apache.org> wrote:

> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M11 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>    processing to pause, and potentially timeout, waiting for additional
>    data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>    non request threads but which introduced a similar problem when user
>    code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>    fields, ensure that any custom type conversion is considered when
>    identifying the method to call.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1360
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M12
> d08498a3cefa7206bad791acf019455794f865ea
>
>
> The proposed 10.1.0-M12 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)
>

Was there a change in dependencies?  I get an error while trying to run
`ant clean test` using Java 11.0.14 on Ubuntu 20.04:

package:
      [jar] Building jar:
/workspace/build/tomcat/main/build/lib/annotations-api.jar

add-osgi:
     [echo] add-osgi
/workspace/build/tomcat/main/build/lib/annotations-api.jar true
      [bnd] [main] WARN aQute.bnd.plugin.jpms.JPMSModuleInfoPlugin - Using
module name 'jakarta.annotation' for: Jar:annotations-api
      [bnd] 2 ERRORS
      [bnd]  Input file does not exist:
../../output/manifests/default.license
      [bnd]  Input file does not exist:
../../output/manifests/default.notice
      [bnd] /workspace/src/tomcat/main/res/bnd/annotations-api.jar.tmp.bnd:
bnd failed
      [bnd] at
aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:231)
      [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:117)
      [bnd] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
      [bnd] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown
Source)
      [bnd] at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      [bnd] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
      [bnd] at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
      [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
      ...
BUILD FAILED
/workspace/src/tomcat/main/build.xml:1036: The following error occurred
while executing this line:
/workspace/src/tomcat/main/build.xml:3798: The following error occurred
while executing this line:
/workspace/src/tomcat/main/build.xml:3820: Failed to build jar file:


Igal




>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.1.0-M12

Posted by Igal Sapir <is...@apache.org>.
On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas <ma...@apache.org> wrote:

> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M11 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>    processing to pause, and potentially timeout, waiting for additional
>    data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>    non request threads but which introduced a similar problem when user
>    code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>    fields, ensure that any custom type conversion is considered when
>    identifying the method to call.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1360
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M12
> d08498a3cefa7206bad791acf019455794f865ea
>
>
> The proposed 10.1.0-M12 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M12 (alpha)
>

Unit tests passed on Ubuntu 20.04 with Java 11.0.14 after patching BZ-65951
[1] which is a minor bug and IMHO should not affect the release.

Igal

[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=65951


>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.1.0-M12

Posted by Rémy Maucherat <re...@apache.org>.
On Wed, Mar 9, 2022 at 2:59 PM Mark Thomas <ma...@apache.org> wrote:
>
> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M11 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>    processing to pause, and potentially timeout, waiting for additional
>    data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>    non request threads but which introduced a similar problem when user
>    code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>    fields, ensure that any custom type conversion is considered when
>    identifying the method to call.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1360
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M12
> d08498a3cefa7206bad791acf019455794f865ea
>
>
> The proposed 10.1.0-M12 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M12 (alpha)

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[VOTE][RESULT] Release Apache Tomcat 10.1.0-M12

Posted by Mark Thomas <ma...@apache.org>.
The following votes were case:

Binding:
+1: markt, remm, isapir

No other votes were cast. The vote therefore passes.

Thanks to everyone who contributed to this release.

Mark


On 09/03/2022 13:59, Mark Thomas wrote:
> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> voting.
> 
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
> without changes. Java EE applications designed for Tomcat 9 and earlier 
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
> will automatically convert them to Jakarta EE and copy them to the 
> webapps directory.
> 
> The notable changes compared to 10.1.0-M11 are:
> 
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>    processing to pause, and potentially timeout, waiting for additional
>    data when the full request has been received.
> 
> - Fix a regression introduced with 65757 bugfix which better identified
>    non request threads but which introduced a similar problem when user
>    code was doing sequential operations in a single thread.
> 
> - When resolving methods in EL expressions that use beans and/or static
>    fields, ensure that any custom type conversion is considered when
>    identifying the method to call.
> 
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1360
> 
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M12
> d08498a3cefa7206bad791acf019455794f865ea
> 
> 
> The proposed 10.1.0-M12 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org