[jira] [Commented] (OFBIZ-10420) Session fixation issue

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499336#comment-16499336 ] 

Jacques Le Roux commented on OFBIZ-10420:
-----------------------------------------

Improved at

trunk r1832756  
R17.12 r1832757
 R16.11 r1832758

> Session fixation issue
> ----------------------
>
>                 Key: OFBIZ-10420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10420
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk, 17.12.01, 16.11.04
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 17.12.01, 16.11.05
>
>
> With the security audit tool "IBM Security AppScan Enterprise , Version : 9.0.3.7" A client discovered a [session fixation security issue|https://www.owasp.org/index.php/Session_fixation]
> [OWASP describes here how to fix this kind of issue|https://www.owasp.org/index.php/Session_Management_Cheat_Sheet#Renew_the_Session_ID_After_Any_Privilege_Level_Change]
> I decided to prevents the session fixation by making Tomcat generate a new jsessionId, ultimately put in cookie.
> OWASP also recommends
> <<Other common scenarios must also be considered, such as password changes, permission changes or switching from a regular user role to an administrator role within the web application. For all these web application critical pages, previous session IDs have to be ignored, a new session ID must be assigned to every new request received for the critical resource, and the old or previous session ID must be destroyed. >>
> Password changes go through a new authentication so not a problem, it's a new login, so a new jsessionId.
> I don't think it is necessary to create a new authentication in OFBiz  during "permission changes". In my opinion as it requires data loads, it's up to the admin to handle it, if it ever happens. You rarely (actually never) change permission during a session, do you? Otherwise the admin has to manage it with the user...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)