You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2020/01/30 17:07:54 UTC

[Bug 64106] New: Attributes marked as un-used are being used in Tomcat dbcp implementation

https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

            Bug ID: 64106
           Summary: Attributes marked as un-used are being used in Tomcat
                    dbcp implementation
           Product: Tomcat 9
           Version: 9.0.x
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Documentation
          Assignee: dev@tomcat.apache.org
          Reporter: tarun.kalra@snapon.com
  Target Milestone: -----

Attribute "poolPreparedStatements" and "maxOpenPreparedStatements" are marked
as un-used but are being used in Tomcat dbcp implementation.

This leads to confusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

--- Comment #4 from tarun.kalra@snapon.com ---
Mark, can you please point me to the dbcp documentation for that version ?
Thank You.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|REOPENED                    |RESOLVED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
That is the doc for tomcat-jdbc.

The doc states tomcat-jdbc does not use those attributes.

This is correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
You are mixing up tomcat-jdbc and tomcat-dbcp.

Tomcat JDBC is Tomcat's "home grown" database connection pooling and does not
use poolPreparedStatements

Tomcat DBCP is Tomcat's package renamed fork of Apache Commons DBCP 2.

Tomcat DBCP is used by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

tarun.kalra@snapon.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
                URL|                            |https://tomcat.apache.org/t
                   |                            |omcat-9.0-doc/jdbc-pool.htm
                   |                            |l

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

All,

On 2/1/20 12:49 PM, bugzilla@apache.org wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=64106
> 
> --- Comment #7 from Christopher Schultz
> <ch...@christopherschultz.net> --- If you are looking for some
> specific information, please post to the users' mailing list with a
> question. Based on what you've said so far, are you just asking
> whether prepared statements are pooled? (Please reply/post to the
> list if this is your question.)

FTR, I think this is the answer to the OP's question:

https://tomcat.apache.org/tomcat-9.0-doc/jdbc-pool.html#org.apache.tomca
t.jdbc.pool.interceptor.StatementCache

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl41u2IACgkQHPApP6U8
pFjZxQ//Uk1F890Sx6KX+YG8Da/BAwL8e7R6urdXQnDQ8kZE7V8u0cmq8KK9LMrE
DDPKug5aZc4a1OiOt2HpQoVolj9SmEZgTjkPSjQOWLWje0DHaJYyzc4oi73UmG/Y
0qtx2XUzAw9ZzepEXCl5ADXVgS6x7DwuqvC9FoARGcQb9X+w3ZG7u5UaRZTzgu3M
Eg9yNycu5eS/wPIS45SrSuwONMdDcnS7AldQ/wu4QQnXEYgNbE+WA6/t5hpnQRjs
2OUwF8HQrfq8VuTnsiOKqaU29wxQJGwyiwR5lIzbsEs6cDy8IgCHm6myOC7W+JJ9
n6kkN/JjgqXl354YN/Uui9jSqgypZXgDtptDDVPq5IjVjmyX1UNSXyZJog3GFI8e
aDYI14aujEUnqC8ET2Oc5M/zPL42JWeBPwNirlUzKXh0agfIqTcED03gXN4EBxQC
kTTQUdoX5er8Sc0SDyfGKveFs2tu7FktJwgJT3ofGvyPEg8ICIK6C5hNSfEBETcL
Odl+K8hHnZLi/x4k3pQXgMeklzWstS1A5hdw0sYArH/wjiKwzKi/Rk63C0is/uYQ
gl24x1WUqotlOXAE/fS4Gr4gF+mFtlvqh9iwToz0362a6GxmhwLLzRgLYkdjxoEF
iS5Pw14runuZjRGDyR93HX2ShhD9TfjvYBrG40HVFNs7GhikO/A=
=Lj/p
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

--- Comment #7 from Christopher Schultz <ch...@christopherschultz.net> ---
If you are looking for some specific information, please post to the users'
mailing list with a question. Based on what you've said so far, are you just
asking whether prepared statements are pooled? (Please reply/post to the list
if this is your question.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

tarun.kalra@snapon.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |---

--- Comment #2 from tarun.kalra@snapon.com ---
See the "Common Attributes" heading in the documentation link.

It says "These attributes are shared between commons-dbcp and tomcat-jdbc-pool,
in some cases default values are different."

This is clearly talking about dbcp attributes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

--- Comment #5 from Christopher Schultz <ch...@christopherschultz.net> ---
It's commons-dbcp. Google is your friend.

https://commons.apache.org/proper/commons-dbcp/configuration.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64106] Attributes marked as un-used are being used in Tomcat dbcp implementation

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64106

--- Comment #6 from tarun.kalra@snapon.com ---
Thank You Chris for pointing me to the commons-dbcp.

I was curious about the documentation of tomcat-dbcp. Since there are quite a
bit of changes in tomcat-dbcp vs commons-dbcp. I was hoping to find
documentation which is relevant to tomcat-dbcp and not the one it was copied
from.

Anyways, It makes me believe none exists for tomcat-dbcp specifically.

Thanks Again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org