You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/06/26 01:18:13 UTC

[GitHub] [incubator-mxnet] aaronmarkham commented on a change in pull request #15317: fix doc for the op sort() and argsort()

aaronmarkham commented on a change in pull request #15317: fix doc for the op sort() and argsort()
URL: https://github.com/apache/incubator-mxnet/pull/15317#discussion_r297451736
 
 

 ##########
 File path: src/operator/tensor/ordering_op.cc
 ##########
 @@ -114,7 +114,7 @@ Examples::
              [ 1.,  3.]]
 
   // flattens and then sorts
-  sort(x) = [ 1.,  1.,  3.,  4.]
+  sort(x, axis=None) = [ 1.,  1.,  3.,  4.]
 
 Review comment:
   This sort makes sense. 
   But I'm thrown off by the other example. Sorting along the last axis would be 3 then 4 unless it is descending rather than ascending. Does this need to be specified for clarity?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services