You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/18 10:31:07 UTC
[GitHub] [incubator-nuttx] pussuw opened a new pull request #5780: MPFS: Add board_memorymap.h
pussuw opened a new pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780
Move the target specific memory map to a separate file so there is no
need to copy&paste the __xxram_start etc linker symbols to each file
that needs them.
Also add MMU flags for I/O and kernel areas, they will be needed
when the kernel runs with virtual addresses also.
## Summary
Adds a header file that can be used to access the linker defined memory boundary symbols
## Impact
## Testing
Icicle board knsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pussuw commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829908067
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
Absolutely true, did not even realize there was another mpfs board target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pussuw commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829892090
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
This is not strictly required at all. It is for convenience.
The reason I made this file is that CONFIG_BUILD_KERNEL code will require a memory map, and the linker provided symbols need to be accessible from multiple files. Just to avoid copy&pasting the "extern __foobar" to each file, I made this file which can be used to access the symbols.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829884014
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
What about `m100pfsevp` board? Does it need the same file as well?
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
But you should probably wrap `#include <arch/board/board_memorymap.h>` with `#ifdef CONFIG_MM_KERNEL_HEAP`?
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
I expect that otherwise build should fail
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
I expect that otherwise build for `m100pfsevp` should fail
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
So either `ifdef CONFIG_MM_KERNEL_HEAP` or create an empty `board_memorymap.h` for `m100pfsevp` board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pussuw commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829903876
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
I can of course do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829884014
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
What about `m100pfsevp` board? Does it need the same file as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829905850
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
I expect that otherwise build should fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829894226
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
But you should probably wrap `#include <arch/board/board_memorymap.h>` with `#ifdef CONFIG_MM_KERNEL_HEAP`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829907041
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
So either `ifdef CONFIG_MM_KERNEL_HEAP` or create an empty `board_memorymap.h` for `m100pfsevp` board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pussuw commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829892090
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
This is not strictly required at all. It is for convenience.
The reason I made this file is that CONFIG_BUILD_KERNEL code will require a memory map, and the linker provided symbols need to be accessible from multiple files. Just to avoid copy&pasting the "extern __foobar" to each file, I made this file which can be used to access the symbols.
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
I can of course do that
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
Absolutely true, did not even realize there was another mpfs board target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5780: MPFS: Add board_memorymap.h
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5780:
URL: https://github.com/apache/incubator-nuttx/pull/5780#discussion_r829905850
##########
File path: boards/risc-v/mpfs/icicle/include/board_memorymap.h
##########
@@ -0,0 +1,93 @@
+/****************************************************************************
+ * boards/risc-v/mpfs/icicle/include/board_memorymap.h
Review comment:
I expect that otherwise build for `m100pfsevp` should fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org