[GitHub] [flink] pnowojski commented on a change in pull request #14488: [FLINK-20651] Use Spotless/google-java-format for code formatting/enforcement

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #14488:
URL: https://github.com/apache/flink/pull/14488#discussion_r549251579



##########
File path: .git-blame-ignore-revs
##########
@@ -0,0 +1 @@
+c996ed9372fc550d0a8a97b2b986bf96d26e304c

Review comment:
       ```
   git config blame.ignoreRevsFile .git-blame-ignore-revs
   ```
   Can you document this somewhere? In the project's `.README`?

##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/KeyedProcessOperatorTest.java
##########
@@ -6,9 +6,9 @@
  * to you under the Apache License, Version 2.0 (the
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
- * <p>
+ *

Review comment:
       Don't we require `<p>` in comments? at least in java docs?  Or is it the issue, that we shouldn't have them in the license headers, but only in the java docs?

##########
File path: pom.xml
##########
@@ -1815,6 +1827,47 @@ under the License.
 					</configuration>
 				</plugin>
 
+				<!-- Due to the Flink build setup, "mvn spotless:apply" and "mvn spotless:check"
+				don't work. You have to use the fully qualified name, i.e.
+				"mvn com.diffplug.spotless:spotless-maven-plugin:apply" -->

Review comment:
       Could this be fixed? What's causing this issue?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org