You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2023/01/23 17:26:02 UTC
[GitHub] [jena] afs opened a new pull request, #1724: Check that --loc is used once only.
afs opened a new pull request, #1724:
URL: https://github.com/apache/jena/pull/1724
GitHub issue resolved #1722
Pull request Description:
Includes a lot of reformatting - this are aof the code hasn't been touched in years.
---
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1724: Check that --loc is used once only.
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #1724:
URL: https://github.com/apache/jena/pull/1724#discussion_r1084638556
##########
jena-cmds/src/main/java/tdb/tdbconfig.java:
##########
@@ -52,196 +51,178 @@ public class tdbconfig extends CmdSub
static final String CMD_INFO = "info" ;
static final String CMD_PREFIXES = "prefixes" ;
- static public void main(String... argv)
- {
- CmdTDB.init() ;
+ static public void main(String...argv) {
Review Comment:
Today-I-Learned. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1724: Check that --loc is used once only.
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #1724:
URL: https://github.com/apache/jena/pull/1724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1724: Check that --loc is used once only.
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1724:
URL: https://github.com/apache/jena/pull/1724#discussion_r1084524502
##########
jena-cmds/src/main/java/tdb/tdbconfig.java:
##########
@@ -52,196 +51,178 @@ public class tdbconfig extends CmdSub
static final String CMD_INFO = "info" ;
static final String CMD_PREFIXES = "prefixes" ;
- static public void main(String... argv)
- {
- CmdTDB.init() ;
+ static public void main(String...argv) {
Review Comment:
A space isn't needed.
The Eclipse formatter took it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1724: Check that --loc is used once only.
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #1724:
URL: https://github.com/apache/jena/pull/1724#discussion_r1084455736
##########
jena-cmds/src/main/java/tdb/tdbconfig.java:
##########
@@ -52,196 +51,178 @@ public class tdbconfig extends CmdSub
static final String CMD_INFO = "info" ;
static final String CMD_PREFIXES = "prefixes" ;
- static public void main(String... argv)
- {
- CmdTDB.init() ;
+ static public void main(String...argv) {
Review Comment:
Does it work without space between the `...` and `argv`? I've always thought I had to have at least one space between the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org