[jira] [Commented] (HBASE-15050) Block Ref counting does not work in Region Split cases.

["ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073872#comment-15073872 ] 

ramkrishna.s.vasudevan commented on HBASE-15050:
------------------------------------------------

I think this patch needs one more tweak wrt how the firstKey and lastKey is getting used. Just realised. Let me take a closer look at it.

> Block Ref counting does not work in Region Split cases.
> -------------------------------------------------------
>
>                 Key: HBASE-15050
>                 URL: https://issues.apache.org/jira/browse/HBASE-15050
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15050.patch, HBASE-15050_1.patch
>
>
> The reference counting on the blocks does not work correctly when the HalfStorefileReader is used for compaction/scans. 
> The reason is that getFirstKey and getLastKey API create a new scanner but does not do the needed close() call and because of that we do not decrement the count on the blocks. The same impact will also be observed on the ref count that we maintain on the reader. Issue found when I was trying to test some other feature with lot of evictions. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)