[jira] [Commented] (KUDU-3226) Validate List of Masters for kudu ksck

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KUDU-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300057#comment-17300057 ] 

ASF subversion and git services commented on KUDU-3226:
-------------------------------------------------------

Commit fae223ecb139e0f54161279ee8970098067629c9 in kudu's branch refs/heads/master from Abhishek Chennaka
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=fae223e ]

[tool] KUDU-3226 Validate List of Masters kudu ksck

This patch checks for duplicate kudu masters provided in all of the
kudu command line tools which call ParseMasterAddresses(). Currently
ksck and rebalance (as rebalance calls ksck internally) are the only
commands which throw the reported stack trace as ksck constructs a
map internally for the kudu masters and bombs once it sees duplicate
UUIDs. Other commands do not report any issue currently with duplicate
masters.

The patch only does a string comparison check to detect and report all
the duplicate master(/s). If a user provides the IP address and hostname
of the same master, it won't be able to catch the duplicates. That
seems more of a deliberate attempt rather than a common mistake a user
could make and hence not considering that case.

Also wrote a simple test case to test this functionality. Decided not
to spin up a test cluster for this as this is more of client side check
and a master is not actually contacted.

This change got conflicted with another test i.e.
AdminCliTest.TestAuthzResetCacheIncorrectMasterAddressList. Updated this
test as well to by creating a new external mini cluster with three
masters and running the command in the test with just one master

Change-Id: I2f3b2b7dcf2ac78cb95cf43242651e3ce8fddf6f
Reviewed-on: http://gerrit.cloudera.org:8080/17141
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>


> Validate List of Masters for kudu ksck
> --------------------------------------
>
>                 Key: KUDU-3226
>                 URL: https://issues.apache.org/jira/browse/KUDU-3226
>             Project: Kudu
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: Abhishek
>            Priority: Minor
>              Labels: beginner, newbie, trivial
>
> I recently accidentally included a list of masters where I fat-fingered the host names and included the same node twice.
> I got some stack trace and an error message about duplicate keys inserted into a map.  I eventually figured out what I did wrong, but the error condition was not super helpful.
> Please add an early validation step that explicitly captures this conditions and provides a helpful error message that includes the name of the host name which was duplicated on the command line.
> This happened for me with {{kudu ksck}} but there may be other candidates as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)