You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/01/13 20:24:13 UTC
Review Request 55521: Handle perf versions with more than 3
components.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55521/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Kapil Arya, and Jiang Yan Xu.
Bugs: MESOS-6867
https://issues.apache.org/jira/browse/MESOS-6867
Repository: mesos
Description
-------
Handle perf versions with more than 3 components.
Diffs
-----
src/linux/perf.hpp c7dfe0ac4965a450b25085715502f49bee972b5c
src/linux/perf.cpp aa31982eb5358b7eafa7035f4358a88d3854755f
src/tests/containerizer/perf_tests.cpp e5ee3e71478e167c345e4a9a7c2c306d302b028b
Diff: https://reviews.apache.org/r/55521/diff/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 55521: Handle perf versions with more than 3
components.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55521/#review161635
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55521]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 13, 2017, 8:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55521/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 8:24 p.m.)
>
>
> Review request for mesos, Ian Downes, Kapil Arya, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6552 and MESOS-6867
> https://issues.apache.org/jira/browse/MESOS-6552
> https://issues.apache.org/jira/browse/MESOS-6867
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Handle perf versions with more than 3 components.
>
>
> Diffs
> -----
>
> src/linux/perf.hpp c7dfe0ac4965a450b25085715502f49bee972b5c
> src/linux/perf.cpp aa31982eb5358b7eafa7035f4358a88d3854755f
> src/tests/containerizer/perf_tests.cpp e5ee3e71478e167c345e4a9a7c2c306d302b028b
>
> Diff: https://reviews.apache.org/r/55521/diff/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 55521: Handle perf versions with more than 3
components.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55521/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 10:19 p.m.)
Review request for mesos, Ian Downes, Kapil Arya, and Jiang Yan Xu.
Changes
-------
Rebase.
Bugs: MESOS-6552 and MESOS-6867
https://issues.apache.org/jira/browse/MESOS-6552
https://issues.apache.org/jira/browse/MESOS-6867
Repository: mesos
Description
-------
Handle perf versions with more than 3 components.
Diffs (updated)
-----
src/linux/perf.hpp c7dfe0ac4965a450b25085715502f49bee972b5c
src/linux/perf.cpp aa31982eb5358b7eafa7035f4358a88d3854755f
src/tests/containerizer/perf_tests.cpp e5ee3e71478e167c345e4a9a7c2c306d302b028b
Diff: https://reviews.apache.org/r/55521/diff/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 55521: Handle perf versions with more than 3
components.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55521/#review161641
-----------------------------------------------------------
Ship it!
src/linux/perf.cpp (line 206)
<https://reviews.apache.org/r/55521/#comment232914>
s/perf/`perf`/
- Jiang Yan Xu
On Jan. 13, 2017, 12:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55521/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 12:24 p.m.)
>
>
> Review request for mesos, Ian Downes, Kapil Arya, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6552 and MESOS-6867
> https://issues.apache.org/jira/browse/MESOS-6552
> https://issues.apache.org/jira/browse/MESOS-6867
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Handle perf versions with more than 3 components.
>
>
> Diffs
> -----
>
> src/linux/perf.hpp c7dfe0ac4965a450b25085715502f49bee972b5c
> src/linux/perf.cpp aa31982eb5358b7eafa7035f4358a88d3854755f
> src/tests/containerizer/perf_tests.cpp e5ee3e71478e167c345e4a9a7c2c306d302b028b
>
> Diff: https://reviews.apache.org/r/55521/diff/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 55521: Handle perf versions with more than 3
components.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55521/#review161914
-----------------------------------------------------------
Fix it, then Ship it!
src/linux/perf.hpp (line 55)
<https://reviews.apache.org/r/55521/#comment233198>
s/ only//.
If this API was not suitable as a public API the convention is to put it in an `intenral` namespace so it's more clear to the users (in addition to the comments).
However this one feels fine so I would just remove the word `only`.
- Jiang Yan Xu
On Jan. 13, 2017, 12:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55521/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 12:24 p.m.)
>
>
> Review request for mesos, Ian Downes, Kapil Arya, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6552 and MESOS-6867
> https://issues.apache.org/jira/browse/MESOS-6552
> https://issues.apache.org/jira/browse/MESOS-6867
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Handle perf versions with more than 3 components.
>
>
> Diffs
> -----
>
> src/linux/perf.hpp c7dfe0ac4965a450b25085715502f49bee972b5c
> src/linux/perf.cpp aa31982eb5358b7eafa7035f4358a88d3854755f
> src/tests/containerizer/perf_tests.cpp e5ee3e71478e167c345e4a9a7c2c306d302b028b
>
> Diff: https://reviews.apache.org/r/55521/diff/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 55521: Handle perf versions with more than 3
components.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55521/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 8:24 p.m.)
Review request for mesos, Ian Downes, Kapil Arya, and Jiang Yan Xu.
Bugs: MESOS-6552 and MESOS-6867
https://issues.apache.org/jira/browse/MESOS-6552
https://issues.apache.org/jira/browse/MESOS-6867
Repository: mesos
Description
-------
Handle perf versions with more than 3 components.
Diffs
-----
src/linux/perf.hpp c7dfe0ac4965a450b25085715502f49bee972b5c
src/linux/perf.cpp aa31982eb5358b7eafa7035f4358a88d3854755f
src/tests/containerizer/perf_tests.cpp e5ee3e71478e167c345e4a9a7c2c306d302b028b
Diff: https://reviews.apache.org/r/55521/diff/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach