You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/21 13:51:54 UTC
[GitHub] [superset] Yann-J opened a new pull request, #22181: build(docker): Push websocket image
Yann-J opened a new pull request, #22181:
URL: https://github.com/apache/superset/pull/22181
### SUMMARY
This PR is a followup to #21954 which was missing the step to actually push the freshly-built `superset-websocket` image to Docker hub.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
This can only be tested after merge, since the publication step is only run on `master`. After successful merge, we should see an `apache/superset-websocket` image in Docker hub, with the same tags as the main image.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #22126
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Yann-J commented on pull request #22181: build(docker): Push websocket image
Posted by GitBox <gi...@apache.org>.
Yann-J commented on PR #22181:
URL: https://github.com/apache/superset/pull/22181#issuecomment-1326675739
Thanks @craig-rueda !
I see the build was successful, and the push was started off as expected, but then rejected by Docker Hub.
I _think_ someone needs to just create the project in Docker Hub to unblock this - although I cannot be certain. In any case it's definitely something on Docker Hub side, which I don't think external contributors like me can fix...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #22181: build(docker): Push websocket image
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22181:
URL: https://github.com/apache/superset/pull/22181#issuecomment-1326641075
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #22181: build(docker): Push websocket image
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #22181:
URL: https://github.com/apache/superset/pull/22181#issuecomment-1333850855
@craig-rueda It seems all master commits are failing after this PR. Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #22181: build(docker): Push websocket image
Posted by GitBox <gi...@apache.org>.
craig-rueda merged PR #22181:
URL: https://github.com/apache/superset/pull/22181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org