Re: [PR] feat(csharp/src/Drivers/Databricks): Added decimalColumnScale connection param [arrow-adbc]

["msrathore-db (via GitHub)" <gi...@apache.org>]

msrathore-db commented on code in PR #3473:
URL: https://github.com/apache/arrow-adbc/pull/3473#discussion_r2376539622


##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -448,6 +468,11 @@ protected internal override bool TrySetGetDirectResults(IRequest request)
         /// </summary>
         public bool RunAsyncInThrift => _runAsyncInThrift;
 
+        /// <summary>
+        /// Gets the decimal column scale value.
+        /// </summary>
+        public int DecimalColumnScale => _decimalColumnScale;

Review Comment:
   As explained in the jira, this param was not actually being used in ODBC and simba JDBC either since thrift already provides a default scale of 0. 
   I'll run test on different spark versions to see any changes.
   Once confirmed for the other DBR versions, I can complete this PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org