You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pentschev (via GitHub)" <gi...@apache.org> on 2023/10/25 06:25:53 UTC
[PR] MINOR: [Python] Deduplicate `ensure_s3_initialized()` call [arrow]
pentschev opened a new pull request, #38451:
URL: https://github.com/apache/arrow/pull/38451
### Rationale for this change
https://github.com/apache/arrow/pull/38375 introduced duplicate calls to `ensure_s3_initialized()`.
### What changes are included in this PR?
Deduplicates call to `ensure_s3_initialized()`.
### Are these changes tested?
Yes, covered by existing S3 tests.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python] Deduplicate `ensure_s3_initialized()` call [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38451:
URL: https://github.com/apache/arrow/pull/38451#issuecomment-1782367222
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit ff7b3bba3262c38ba94041aaf0143c0217e41457.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/18110008323) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python] Deduplicate `ensure_s3_initialized()` call [arrow]
Posted by "bdice (via GitHub)" <gi...@apache.org>.
bdice commented on PR #38451:
URL: https://github.com/apache/arrow/pull/38451#issuecomment-1780055178
The failing Appveyor tests look similar to ones I just encountered. These may be solved by this PR to update the `s3fs` strings used to determine which tests should be `xfail`'d. https://github.com/apache/arrow/pull/38455 I just ran into the same problem while backporting this patch: https://github.com/conda-forge/arrow-cpp-feedstock/pull/1211#issuecomment-1780022670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python] Deduplicate `ensure_s3_initialized()` call [arrow]
Posted by "pentschev (via GitHub)" <gi...@apache.org>.
pentschev commented on PR #38451:
URL: https://github.com/apache/arrow/pull/38451#issuecomment-1778595498
@kou as per https://github.com/apache/arrow/pull/38375#issuecomment-1778077582, here's the PR to deduplicate the `ensure_s3_initialized()`. Thanks for catching that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python] Deduplicate `ensure_s3_initialized()` call [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #38451:
URL: https://github.com/apache/arrow/pull/38451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python] Deduplicate `ensure_s3_initialized()` call [arrow]
Posted by "jakirkham (via GitHub)" <gi...@apache.org>.
jakirkham commented on PR #38451:
URL: https://github.com/apache/arrow/pull/38451#issuecomment-1780227878
Thanks all! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python] Deduplicate `ensure_s3_initialized()` call [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38451:
URL: https://github.com/apache/arrow/pull/38451#issuecomment-1779973998
Revision: 4023801ff98ee095dd28aad7ab040750a01fc6c0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-89f99927a7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-89f99927a7)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/tree/actions-89f99927a7-github-test-conda-python-3.10)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/6645525950/job/18057048253)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/6645541619/job/18057094291)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6645553443/job/18057131882)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6645555283/job/18057137716)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/6645534438/job/18057073664)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6645554824/job/18057136333)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/6645526304/job/18057054953)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6645532748/job/18057067902)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6645552532/job/18057128933)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6645535685/job/18057078101)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/6645551980/job/18057126650)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6645543459/job/18057101568)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/6645543110/job/18057099789)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/6645533253/job/18057069240)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/6645534812/job/18057075036)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6645532103/job/18057065890)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6645556062/job/18057139822)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/6645556643/job/18057141273)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6645530866/job/18057062376)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6645551588/job/18057125109)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/18057098187)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/18057087865)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/18057060870)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/6645538896/job/18057087401)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645534106/job/18057072366)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645545867/job/18057109728)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645549206/job/18057118321)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645526695/job/18057055043)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645539653/job/18057089241)|
|wheel-macos-mojave-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645557287/job/18057143213)|
|wheel-macos-mojave-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645537887/job/18057084437)|
|wheel-macos-mojave-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645540986/job/18057092577)|
|wheel-macos-mojave-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645528384/job/18057055698)|
|wheel-macos-mojave-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645529034/job/18057057353)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645536038/job/18057079236)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645550577/job/18057121778)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645549916/job/18057119997)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645530295/job/18057061061)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645553016/job/18057130416)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645537083/job/18057082400)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645553719/job/18057132850)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645542628/job/18057097601)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645535225/job/18057076844)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645552306/job/18057127863)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645546498/job/18057111264)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645554323/job/18057134711)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645531501/job/18057064275)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645547949/job/18057114979)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645543736/job/18057102866)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645540280/job/18057090900)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645527227/job/18057054962)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645544451/job/18057105465)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645527725/job/18057054941)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645544058/job/18057103908)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645544842/job/18057106589)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645548601/job/18057116487)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645536616/job/18057081149)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645545344/job/18057108108)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6645533682/job/18057070676)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python] Deduplicate `ensure_s3_initialized()` call [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38451:
URL: https://github.com/apache/arrow/pull/38451#issuecomment-1779965387
@github-actions crossbow submit -g python -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org