You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2020/02/14 12:03:34 UTC

[DISCUSS]/[PROPOSAL] draft PRs

devs, I thought I had already sent a mail about this but i cannot find it.
I'm sure i had mentioned it somewhere (probably on github).
this is a follow up on [1] and hopefully you'll agree, a slight improvement.

here it comes:

At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the
title. This title stands the chance of being merged once we agree the PR is
ready for merge. It also clutters the title.

Github has introduced a nice feature a while ago; draft PR. When creating a
PR you can opt not to open it for merge but as draft. Choose a button left
of the "Create pull request" button, marked "Create draft PR". It will be a
full PR with all CI and discussion possibilities open. The only difference
is the merge button being disabled. One will than have to make/mark it
"ready for merge" before it *can* be merged.

[1]
https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
please shoot any comments you may have back at me,
thanks

-- 
Daan

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Gabriel Beims Bräscher <ga...@gmail.com>.
+1 from me :)

On Fri, Feb 14, 2020, 09:48 Sven Vogel <S....@ewerk.com> wrote:

> +1 (The title are better readable)
>
>
> __
>
> Sven Vogel
> Teamlead Platform
>
> EWERK DIGITAL GmbH
> Brühl 24, D-04109 Leipzig
> P +49 341 42649 - 99
> F +49 341 42649 - 98
> S.Vogel@ewerk.com
> www.ewerk.com
>
> Geschäftsführer:
> Dr. Erik Wende, Hendrik Schubert, Frank Richter
> Registergericht: Leipzig HRB 9065
>
> Zertifiziert nach:
> ISO/IEC 27001:2013
> DIN EN ISO 9001:2015
> DIN ISO/IEC 20000-1:2011
>
> EWERK-Blog | LinkedIn | Xing | Twitter | Facebook
>
> Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.
>
> Disclaimer Privacy:
> Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist
> vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der
> bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung,
> Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte
> informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie
> die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System.
> Vielen Dank.
>
> The contents of this e-mail (including any attachments) are confidential
> and may be legally privileged. If you are not the intended recipient of
> this e-mail, any disclosure, copying, distribution or use of its contents
> is strictly prohibited, and you should please notify the sender immediately
> and then delete it (including any attachments) from your system. Thank you.
> > Am 14.02.2020 um 13:42 schrieb Andrija Panic <an...@gmail.com>:
> >
> > +1
> >
> >> On Fri, 14 Feb 2020 at 13:18, Wido den Hollander <wi...@widodh.nl>
> wrote:
> >>
> >>
> >>
> >>> On 2/14/20 1:03 PM, Daan Hoogland wrote:
> >>> devs, I thought I had already sent a mail about this but i cannot find
> >> it.
> >>> I'm sure i had mentioned it somewhere (probably on github).
> >>> this is a follow up on [1] and hopefully you'll agree, a slight
> >> improvement.
> >>>
> >>> here it comes:
> >>>
> >>> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in
> >> the
> >>> title. This title stands the chance of being merged once we agree the
> PR
> >> is
> >>> ready for merge. It also clutters the title.
> >>>
> >>> Github has introduced a nice feature a while ago; draft PR. When
> >> creating a
> >>> PR you can opt not to open it for merge but as draft. Choose a button
> >> left
> >>> of the "Create pull request" button, marked "Create draft PR". It will
> >> be a
> >>> full PR with all CI and discussion possibilities open. The only
> >> difference
> >>> is the merge button being disabled. One will than have to make/mark it
> >>> "ready for merge" before it *can* be merged.
> >>>
> >>
> >> That sounds like a good idea! Would be a +1 from me :-)
> >>
> >> Wido
> >>
> >>> [1]
> >>>
> >>
> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
> >>> please shoot any comments you may have back at me,
> >>> thanks
> >>>
> >>
> >
> >
> > --
> >
> > Andrija Panić
>

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Sven Vogel <S....@ewerk.com>.
+1 (The title are better readable)


__

Sven Vogel
Teamlead Platform

EWERK DIGITAL GmbH
Brühl 24, D-04109 Leipzig
P +49 341 42649 - 99
F +49 341 42649 - 98
S.Vogel@ewerk.com
www.ewerk.com

Geschäftsführer:
Dr. Erik Wende, Hendrik Schubert, Frank Richter
Registergericht: Leipzig HRB 9065

Zertifiziert nach:
ISO/IEC 27001:2013
DIN EN ISO 9001:2015
DIN ISO/IEC 20000-1:2011

EWERK-Blog | LinkedIn | Xing | Twitter | Facebook

Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.

Disclaimer Privacy:
Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen Dank.

The contents of this e-mail (including any attachments) are confidential and may be legally privileged. If you are not the intended recipient of this e-mail, any disclosure, copying, distribution or use of its contents is strictly prohibited, and you should please notify the sender immediately and then delete it (including any attachments) from your system. Thank you.
> Am 14.02.2020 um 13:42 schrieb Andrija Panic <an...@gmail.com>:
>
> +1
>
>> On Fri, 14 Feb 2020 at 13:18, Wido den Hollander <wi...@widodh.nl> wrote:
>>
>>
>>
>>> On 2/14/20 1:03 PM, Daan Hoogland wrote:
>>> devs, I thought I had already sent a mail about this but i cannot find
>> it.
>>> I'm sure i had mentioned it somewhere (probably on github).
>>> this is a follow up on [1] and hopefully you'll agree, a slight
>> improvement.
>>>
>>> here it comes:
>>>
>>> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in
>> the
>>> title. This title stands the chance of being merged once we agree the PR
>> is
>>> ready for merge. It also clutters the title.
>>>
>>> Github has introduced a nice feature a while ago; draft PR. When
>> creating a
>>> PR you can opt not to open it for merge but as draft. Choose a button
>> left
>>> of the "Create pull request" button, marked "Create draft PR". It will
>> be a
>>> full PR with all CI and discussion possibilities open. The only
>> difference
>>> is the merge button being disabled. One will than have to make/mark it
>>> "ready for merge" before it *can* be merged.
>>>
>>
>> That sounds like a good idea! Would be a +1 from me :-)
>>
>> Wido
>>
>>> [1]
>>>
>> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
>>> please shoot any comments you may have back at me,
>>> thanks
>>>
>>
>
>
> --
>
> Andrija Panić

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Andrija Panic <an...@gmail.com>.
+1

On Fri, 14 Feb 2020 at 13:18, Wido den Hollander <wi...@widodh.nl> wrote:

>
>
> On 2/14/20 1:03 PM, Daan Hoogland wrote:
> > devs, I thought I had already sent a mail about this but i cannot find
> it.
> > I'm sure i had mentioned it somewhere (probably on github).
> > this is a follow up on [1] and hopefully you'll agree, a slight
> improvement.
> >
> > here it comes:
> >
> > At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in
> the
> > title. This title stands the chance of being merged once we agree the PR
> is
> > ready for merge. It also clutters the title.
> >
> > Github has introduced a nice feature a while ago; draft PR. When
> creating a
> > PR you can opt not to open it for merge but as draft. Choose a button
> left
> > of the "Create pull request" button, marked "Create draft PR". It will
> be a
> > full PR with all CI and discussion possibilities open. The only
> difference
> > is the merge button being disabled. One will than have to make/mark it
> > "ready for merge" before it *can* be merged.
> >
>
> That sounds like a good idea! Would be a +1 from me :-)
>
> Wido
>
> > [1]
> >
> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
> > please shoot any comments you may have back at me,
> > thanks
> >
>


-- 

Andrija Panić

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Wido den Hollander <wi...@widodh.nl>.

On 2/14/20 1:03 PM, Daan Hoogland wrote:
> devs, I thought I had already sent a mail about this but i cannot find it.
> I'm sure i had mentioned it somewhere (probably on github).
> this is a follow up on [1] and hopefully you'll agree, a slight improvement.
> 
> here it comes:
> 
> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the
> title. This title stands the chance of being merged once we agree the PR is
> ready for merge. It also clutters the title.
> 
> Github has introduced a nice feature a while ago; draft PR. When creating a
> PR you can opt not to open it for merge but as draft. Choose a button left
> of the "Create pull request" button, marked "Create draft PR". It will be a
> full PR with all CI and discussion possibilities open. The only difference
> is the merge button being disabled. One will than have to make/mark it
> "ready for merge" before it *can* be merged.
> 

That sounds like a good idea! Would be a +1 from me :-)

Wido

> [1]
> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
> please shoot any comments you may have back at me,
> thanks
>

RE: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Paul Angus <pa...@shapeblue.com>.
+1

I've also created a script that trawls our PRs to both label and create a report.  Right now it uses the Draft 'type' to figure out what's 'coming soon'.
Ps. Once polished I plan to contribute the docker containers that takes away all 'environment creation' hassles.


paul.angus@shapeblue.com 
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue
  
 


-----Original Message-----
From: Abhishek Kumar <Ab...@shapeblue.com> 
Sent: 17 February 2020 11:09
To: Daan Hoogland <da...@gmail.com>; dev <de...@cloudstack.apache.org>
Subject: Re: [DISCUSS]/[PROPOSAL] draft PRs

+1
________________________________
From: Daan Hoogland <da...@gmail.com>
Sent: 14 February 2020 17:33
To: dev <de...@cloudstack.apache.org>
Subject: [DISCUSS]/[PROPOSAL] draft PRs

devs, I thought I had already sent a mail about this but i cannot find it.
I'm sure i had mentioned it somewhere (probably on github).
this is a follow up on [1] and hopefully you'll agree, a slight improvement.

here it comes:

At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the title. This title stands the chance of being merged once we agree the PR is ready for merge. It also clutters the title.

Github has introduced a nice feature a while ago; draft PR. When creating a PR you can opt not to open it for merge but as draft. Choose a button left of the "Create pull request" button, marked "Create draft PR". It will be a full PR with all CI and discussion possibilities open. The only difference is the merge button being disabled. One will than have to make/mark it "ready for merge" before it *can* be merged.

[1]
https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
please shoot any comments you may have back at me, thanks

--
Daan

Abhishek.Kumar@shapeblue.com
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK @shapeblue

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Abhishek Kumar <Ab...@shapeblue.com>.
+1
________________________________
From: Daan Hoogland <da...@gmail.com>
Sent: 14 February 2020 17:33
To: dev <de...@cloudstack.apache.org>
Subject: [DISCUSS]/[PROPOSAL] draft PRs

devs, I thought I had already sent a mail about this but i cannot find it.
I'm sure i had mentioned it somewhere (probably on github).
this is a follow up on [1] and hopefully you'll agree, a slight improvement.

here it comes:

At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the
title. This title stands the chance of being merged once we agree the PR is
ready for merge. It also clutters the title.

Github has introduced a nice feature a while ago; draft PR. When creating a
PR you can opt not to open it for merge but as draft. Choose a button left
of the "Create pull request" button, marked "Create draft PR". It will be a
full PR with all CI and discussion possibilities open. The only difference
is the merge button being disabled. One will than have to make/mark it
"ready for merge" before it *can* be merged.

[1]
https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
please shoot any comments you may have back at me,
thanks

--
Daan

Abhishek.Kumar@shapeblue.com 
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Simon Weller <sw...@ena.com.INVALID>.
+1
________________________________
From: Daan Hoogland <da...@gmail.com>
Sent: Friday, February 14, 2020 6:03 AM
To: dev <de...@cloudstack.apache.org>
Subject: [DISCUSS]/[PROPOSAL] draft PRs

devs, I thought I had already sent a mail about this but i cannot find it.
I'm sure i had mentioned it somewhere (probably on github).
this is a follow up on [1] and hopefully you'll agree, a slight improvement.

here it comes:

At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the
title. This title stands the chance of being merged once we agree the PR is
ready for merge. It also clutters the title.

Github has introduced a nice feature a while ago; draft PR. When creating a
PR you can opt not to open it for merge but as draft. Choose a button left
of the "Create pull request" button, marked "Create draft PR". It will be a
full PR with all CI and discussion possibilities open. The only difference
is the merge button being disabled. One will than have to make/mark it
"ready for merge" before it *can* be merged.

[1]
https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
please shoot any comments you may have back at me,
thanks

--
Daan

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Wei ZHOU <us...@gmail.com>.
good idea.

it seems all checks and tests can still work, from example
https://github.com/apache/cloudstack/pull/3768

-Wei

On Fri, 14 Feb 2020 at 13:03, Daan Hoogland <da...@gmail.com> wrote:

> devs, I thought I had already sent a mail about this but i cannot find it.
> I'm sure i had mentioned it somewhere (probably on github).
> this is a follow up on [1] and hopefully you'll agree, a slight
> improvement.
>
> here it comes:
>
> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the
> title. This title stands the chance of being merged once we agree the PR is
> ready for merge. It also clutters the title.
>
> Github has introduced a nice feature a while ago; draft PR. When creating a
> PR you can opt not to open it for merge but as draft. Choose a button left
> of the "Create pull request" button, marked "Create draft PR". It will be a
> full PR with all CI and discussion possibilities open. The only difference
> is the merge button being disabled. One will than have to make/mark it
> "ready for merge" before it *can* be merged.
>
> [1]
>
> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
> please shoot any comments you may have back at me,
> thanks
>
> --
> Daan
>

RE: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Paul Angus <pa...@shapeblue.com>.
Great work Daan!

paul.angus@shapeblue.com 
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue
  
 


-----Original Message-----
From: Daan Hoogland <da...@gmail.com> 
Sent: 14 February 2020 18:45
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS]/[PROPOSAL] draft PRs

Thanks all for the swift responses. Let's just start doing this. No need for a vote until someone starts a discussion on the subject. Agree?

On Fri, 14 Feb 2020, 17:04 Rohit Yadav, <ro...@shapeblue.com> wrote:

> +1 (better than changing the PR subject, putting wip-labels or [WIP])
>
> Regards,
>
> Rohit Yadav
>
> Software Architect, ShapeBlue
> https://www.shapeblue.com
>
> rohit.yadav@shapeblue.com
> www.shapeblue.com
> @shapeblue
>
>
>
> ------------------------------
> *From:* Daan Hoogland <da...@gmail.com>
> *Sent:* Friday, February 14, 2020 17:33
> *To:* dev <de...@cloudstack.apache.org>
> *Subject:* [DISCUSS]/[PROPOSAL] draft PRs
>
> devs, I thought I had already sent a mail about this but i cannot find it.
> I'm sure i had mentioned it somewhere (probably on github).
> this is a follow up on [1] and hopefully you'll agree, a slight 
> improvement.
>
> here it comes:
>
> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag 
> in the title. This title stands the chance of being merged once we 
> agree the PR is ready for merge. It also clutters the title.
>
> Github has introduced a nice feature a while ago; draft PR. When 
> creating a PR you can opt not to open it for merge but as draft. 
> Choose a button left of the "Create pull request" button, marked 
> "Create draft PR". It will be a full PR with all CI and discussion 
> possibilities open. The only difference is the merge button being 
> disabled. One will than have to make/mark it "ready for merge" before it *can* be merged.
>
> [1]
>
> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037
> f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
> please shoot any comments you may have back at me, thanks
>
> --
> Daan
>

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Sven Vogel <S....@ewerk.com>.
Hi Daan,

K. I will look where I can put it into the confluence. Maybe or hope I will find a place. will say that I got this email. Maybe someone don’t get this mail eg another dev and then it’s easy to say there is an entry in the conf. Mailing lists are like a waterfall. you forget or don’t see it again in the moment it passes.

Cheers

Sven


__

Sven Vogel
Teamlead Platform

EWERK DIGITAL GmbH
Brühl 24, D-04109 Leipzig
P +49 341 42649 - 99
F +49 341 42649 - 98
S.Vogel@ewerk.com
www.ewerk.com

Geschäftsführer:
Dr. Erik Wende, Hendrik Schubert, Frank Richter
Registergericht: Leipzig HRB 9065

Zertifiziert nach:
ISO/IEC 27001:2013
DIN EN ISO 9001:2015
DIN ISO/IEC 20000-1:2011

EWERK-Blog | LinkedIn | Xing | Twitter | Facebook

Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.

Disclaimer Privacy:
Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen Dank.

The contents of this e-mail (including any attachments) are confidential and may be legally privileged. If you are not the intended recipient of this e-mail, any disclosure, copying, distribution or use of its contents is strictly prohibited, and you should please notify the sender immediately and then delete it (including any attachments) from your system. Thank you.
> Am 14.02.2020 um 23:37 schrieb Daan Hoogland <da...@gmail.com>:
>
> Feel free to do so, Sven. I'm  not aware that the initial proposal got to
> confluence, but it should be added there if it did.
>
>> On Fri, 14 Feb 2020, 22:33 Sven Vogel, <S....@ewerk.com> wrote:
>>
>> Should we add this to the confluence?
>>
>>
>> __
>>
>> Sven Vogel
>> Teamlead Platform
>>
>> EWERK DIGITAL GmbH
>> Brühl 24, D-04109 Leipzig
>> P +49 341 42649 - 99
>> F +49 341 42649 - 98
>> S.Vogel@ewerk.com
>> www.ewerk.com
>>
>> Geschäftsführer:
>> Dr. Erik Wende, Hendrik Schubert, Frank Richter
>> Registergericht: Leipzig HRB 9065
>>
>> Zertifiziert nach:
>> ISO/IEC 27001:2013
>> DIN EN ISO 9001:2015
>> DIN ISO/IEC 20000-1:2011
>>
>> EWERK-Blog | LinkedIn | Xing | Twitter | Facebook
>>
>> Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.
>>
>> Disclaimer Privacy:
>> Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist
>> vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der
>> bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung,
>> Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte
>> informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie
>> die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System.
>> Vielen Dank.
>>
>> The contents of this e-mail (including any attachments) are confidential
>> and may be legally privileged. If you are not the intended recipient of
>> this e-mail, any disclosure, copying, distribution or use of its contents
>> is strictly prohibited, and you should please notify the sender immediately
>> and then delete it (including any attachments) from your system. Thank you.
>>>> Am 14.02.2020 um 19:45 schrieb Daan Hoogland <da...@gmail.com>:
>>>
>>> Thanks all for the swift responses. Let's just start doing this. No need
>>> for a vote until someone starts a discussion on the subject. Agree?
>>>
>>>> On Fri, 14 Feb 2020, 17:04 Rohit Yadav, <ro...@shapeblue.com>
>> wrote:
>>>>
>>>> +1 (better than changing the PR subject, putting wip-labels or [WIP])
>>>>
>>>> Regards,
>>>>
>>>> Rohit Yadav
>>>>
>>>> Software Architect, ShapeBlue
>>>> https://www.shapeblue.com
>>>>
>>>> rohit.yadav@shapeblue.com
>>>> www.shapeblue.com
>>>> @shapeblue
>>>>
>>>>
>>>>
>>>> ------------------------------
>>>> *From:* Daan Hoogland <da...@gmail.com>
>>>> *Sent:* Friday, February 14, 2020 17:33
>>>> *To:* dev <de...@cloudstack.apache.org>
>>>> *Subject:* [DISCUSS]/[PROPOSAL] draft PRs
>>>>
>>>> devs, I thought I had already sent a mail about this but i cannot find
>> it.
>>>> I'm sure i had mentioned it somewhere (probably on github).
>>>> this is a follow up on [1] and hopefully you'll agree, a slight
>>>> improvement.
>>>>
>>>> here it comes:
>>>>
>>>> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in
>> the
>>>> title. This title stands the chance of being merged once we agree the
>> PR is
>>>> ready for merge. It also clutters the title.
>>>>
>>>> Github has introduced a nice feature a while ago; draft PR. When
>> creating a
>>>> PR you can opt not to open it for merge but as draft. Choose a button
>> left
>>>> of the "Create pull request" button, marked "Create draft PR". It will
>> be a
>>>> full PR with all CI and discussion possibilities open. The only
>> difference
>>>> is the merge button being disabled. One will than have to make/mark it
>>>> "ready for merge" before it *can* be merged.
>>>>
>>>> [1]
>>>>
>>>>
>> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
>>>> please shoot any comments you may have back at me,
>>>> thanks
>>>>
>>>> --
>>>> Daan
>>>>
>>

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Daan Hoogland <da...@gmail.com>.
Feel free to do so, Sven. I'm  not aware that the initial proposal got to
confluence, but it should be added there if it did.

On Fri, 14 Feb 2020, 22:33 Sven Vogel, <S....@ewerk.com> wrote:

> Should we add this to the confluence?
>
>
> __
>
> Sven Vogel
> Teamlead Platform
>
> EWERK DIGITAL GmbH
> Brühl 24, D-04109 Leipzig
> P +49 341 42649 - 99
> F +49 341 42649 - 98
> S.Vogel@ewerk.com
> www.ewerk.com
>
> Geschäftsführer:
> Dr. Erik Wende, Hendrik Schubert, Frank Richter
> Registergericht: Leipzig HRB 9065
>
> Zertifiziert nach:
> ISO/IEC 27001:2013
> DIN EN ISO 9001:2015
> DIN ISO/IEC 20000-1:2011
>
> EWERK-Blog | LinkedIn | Xing | Twitter | Facebook
>
> Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.
>
> Disclaimer Privacy:
> Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist
> vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der
> bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung,
> Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte
> informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie
> die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System.
> Vielen Dank.
>
> The contents of this e-mail (including any attachments) are confidential
> and may be legally privileged. If you are not the intended recipient of
> this e-mail, any disclosure, copying, distribution or use of its contents
> is strictly prohibited, and you should please notify the sender immediately
> and then delete it (including any attachments) from your system. Thank you.
> > Am 14.02.2020 um 19:45 schrieb Daan Hoogland <da...@gmail.com>:
> >
> > Thanks all for the swift responses. Let's just start doing this. No need
> > for a vote until someone starts a discussion on the subject. Agree?
> >
> >> On Fri, 14 Feb 2020, 17:04 Rohit Yadav, <ro...@shapeblue.com>
> wrote:
> >>
> >> +1 (better than changing the PR subject, putting wip-labels or [WIP])
> >>
> >> Regards,
> >>
> >> Rohit Yadav
> >>
> >> Software Architect, ShapeBlue
> >> https://www.shapeblue.com
> >>
> >> rohit.yadav@shapeblue.com
> >> www.shapeblue.com
> >> @shapeblue
> >>
> >>
> >>
> >> ------------------------------
> >> *From:* Daan Hoogland <da...@gmail.com>
> >> *Sent:* Friday, February 14, 2020 17:33
> >> *To:* dev <de...@cloudstack.apache.org>
> >> *Subject:* [DISCUSS]/[PROPOSAL] draft PRs
> >>
> >> devs, I thought I had already sent a mail about this but i cannot find
> it.
> >> I'm sure i had mentioned it somewhere (probably on github).
> >> this is a follow up on [1] and hopefully you'll agree, a slight
> >> improvement.
> >>
> >> here it comes:
> >>
> >> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in
> the
> >> title. This title stands the chance of being merged once we agree the
> PR is
> >> ready for merge. It also clutters the title.
> >>
> >> Github has introduced a nice feature a while ago; draft PR. When
> creating a
> >> PR you can opt not to open it for merge but as draft. Choose a button
> left
> >> of the "Create pull request" button, marked "Create draft PR". It will
> be a
> >> full PR with all CI and discussion possibilities open. The only
> difference
> >> is the merge button being disabled. One will than have to make/mark it
> >> "ready for merge" before it *can* be merged.
> >>
> >> [1]
> >>
> >>
> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
> >> please shoot any comments you may have back at me,
> >> thanks
> >>
> >> --
> >> Daan
> >>
>

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Sven Vogel <S....@ewerk.com>.
Should we add this to the confluence?


__

Sven Vogel
Teamlead Platform

EWERK DIGITAL GmbH
Brühl 24, D-04109 Leipzig
P +49 341 42649 - 99
F +49 341 42649 - 98
S.Vogel@ewerk.com
www.ewerk.com

Geschäftsführer:
Dr. Erik Wende, Hendrik Schubert, Frank Richter
Registergericht: Leipzig HRB 9065

Zertifiziert nach:
ISO/IEC 27001:2013
DIN EN ISO 9001:2015
DIN ISO/IEC 20000-1:2011

EWERK-Blog | LinkedIn | Xing | Twitter | Facebook

Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.

Disclaimer Privacy:
Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen Dank.

The contents of this e-mail (including any attachments) are confidential and may be legally privileged. If you are not the intended recipient of this e-mail, any disclosure, copying, distribution or use of its contents is strictly prohibited, and you should please notify the sender immediately and then delete it (including any attachments) from your system. Thank you.
> Am 14.02.2020 um 19:45 schrieb Daan Hoogland <da...@gmail.com>:
>
> Thanks all for the swift responses. Let's just start doing this. No need
> for a vote until someone starts a discussion on the subject. Agree?
>
>> On Fri, 14 Feb 2020, 17:04 Rohit Yadav, <ro...@shapeblue.com> wrote:
>>
>> +1 (better than changing the PR subject, putting wip-labels or [WIP])
>>
>> Regards,
>>
>> Rohit Yadav
>>
>> Software Architect, ShapeBlue
>> https://www.shapeblue.com
>>
>> rohit.yadav@shapeblue.com
>> www.shapeblue.com
>> @shapeblue
>>
>>
>>
>> ------------------------------
>> *From:* Daan Hoogland <da...@gmail.com>
>> *Sent:* Friday, February 14, 2020 17:33
>> *To:* dev <de...@cloudstack.apache.org>
>> *Subject:* [DISCUSS]/[PROPOSAL] draft PRs
>>
>> devs, I thought I had already sent a mail about this but i cannot find it.
>> I'm sure i had mentioned it somewhere (probably on github).
>> this is a follow up on [1] and hopefully you'll agree, a slight
>> improvement.
>>
>> here it comes:
>>
>> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the
>> title. This title stands the chance of being merged once we agree the PR is
>> ready for merge. It also clutters the title.
>>
>> Github has introduced a nice feature a while ago; draft PR. When creating a
>> PR you can opt not to open it for merge but as draft. Choose a button left
>> of the "Create pull request" button, marked "Create draft PR". It will be a
>> full PR with all CI and discussion possibilities open. The only difference
>> is the merge button being disabled. One will than have to make/mark it
>> "ready for merge" before it *can* be merged.
>>
>> [1]
>>
>> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
>> please shoot any comments you may have back at me,
>> thanks
>>
>> --
>> Daan
>>

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Daan Hoogland <da...@gmail.com>.
Thanks all for the swift responses. Let's just start doing this. No need
for a vote until someone starts a discussion on the subject. Agree?

On Fri, 14 Feb 2020, 17:04 Rohit Yadav, <ro...@shapeblue.com> wrote:

> +1 (better than changing the PR subject, putting wip-labels or [WIP])
>
> Regards,
>
> Rohit Yadav
>
> Software Architect, ShapeBlue
> https://www.shapeblue.com
>
> rohit.yadav@shapeblue.com
> www.shapeblue.com
> @shapeblue
>
>
>
> ------------------------------
> *From:* Daan Hoogland <da...@gmail.com>
> *Sent:* Friday, February 14, 2020 17:33
> *To:* dev <de...@cloudstack.apache.org>
> *Subject:* [DISCUSS]/[PROPOSAL] draft PRs
>
> devs, I thought I had already sent a mail about this but i cannot find it.
> I'm sure i had mentioned it somewhere (probably on github).
> this is a follow up on [1] and hopefully you'll agree, a slight
> improvement.
>
> here it comes:
>
> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the
> title. This title stands the chance of being merged once we agree the PR is
> ready for merge. It also clutters the title.
>
> Github has introduced a nice feature a while ago; draft PR. When creating a
> PR you can opt not to open it for merge but as draft. Choose a button left
> of the "Create pull request" button, marked "Create draft PR". It will be a
> full PR with all CI and discussion possibilities open. The only difference
> is the merge button being disabled. One will than have to make/mark it
> "ready for merge" before it *can* be merged.
>
> [1]
>
> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
> please shoot any comments you may have back at me,
> thanks
>
> --
> Daan
>

Re: [DISCUSS]/[PROPOSAL] draft PRs

Posted by Rohit Yadav <ro...@shapeblue.com>.
+1 (better than changing the PR subject, putting wip-labels or [WIP])


Regards,

Rohit Yadav

Software Architect, ShapeBlue

https://www.shapeblue.com

________________________________
From: Daan Hoogland <da...@gmail.com>
Sent: Friday, February 14, 2020 17:33
To: dev <de...@cloudstack.apache.org>
Subject: [DISCUSS]/[PROPOSAL] draft PRs

devs, I thought I had already sent a mail about this but i cannot find it.
I'm sure i had mentioned it somewhere (probably on github).
this is a follow up on [1] and hopefully you'll agree, a slight improvement.

here it comes:

At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the
title. This title stands the chance of being merged once we agree the PR is
ready for merge. It also clutters the title.

Github has introduced a nice feature a while ago; draft PR. When creating a
PR you can opt not to open it for merge but as draft. Choose a button left
of the "Create pull request" button, marked "Create draft PR". It will be a
full PR with all CI and discussion possibilities open. The only difference
is the merge button being disabled. One will than have to make/mark it
"ready for merge" before it *can* be merged.

[1]
https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E
please shoot any comments you may have back at me,
thanks

--
Daan

rohit.yadav@shapeblue.com 
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue