You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ap...@apache.org on 2020/09/03 21:51:04 UTC
[incubator-pinot] branch master updated: [TE] Cleanup helm chart.
Removing ingress, traefik. +refactor install.sh (#5971)
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 023003a [TE] Cleanup helm chart. Removing ingress, traefik. +refactor install.sh (#5971)
023003a is described below
commit 023003a3b8b5e3df91a7e20e1825f35b5d22ae87
Author: Suvodeep Pyne <su...@users.noreply.github.com>
AuthorDate: Thu Sep 3 14:50:49 2020 -0700
[TE] Cleanup helm chart. Removing ingress, traefik. +refactor install.sh (#5971)
Changes
- Removing ingress and traefik related configs
- Added helm dependency update to download dependencies while install
---
kubernetes/helm/thirdeye/install.sh | 3 +++
kubernetes/helm/thirdeye/templates/_helpers.tpl | 14 --------------
kubernetes/helm/thirdeye/templates/frontend/ingress.yaml | 14 --------------
kubernetes/helm/thirdeye/values.yaml | 5 -----
4 files changed, 3 insertions(+), 33 deletions(-)
diff --git a/kubernetes/helm/thirdeye/install.sh b/kubernetes/helm/thirdeye/install.sh
index ced9659..83ebdf6 100755
--- a/kubernetes/helm/thirdeye/install.sh
+++ b/kubernetes/helm/thirdeye/install.sh
@@ -3,6 +3,9 @@
base_dir=$(dirname "$0")
cd ${base_dir};
+# fetch dependencies. example: mysql. See Chart.yaml
+helm dependency update
+
# Note:
# - initdb files must end with .sql
# - When injecting yaml config via terminal, the period ('.') must be escaped and quoted
diff --git a/kubernetes/helm/thirdeye/templates/_helpers.tpl b/kubernetes/helm/thirdeye/templates/_helpers.tpl
index d821fb7..720fcb5 100644
--- a/kubernetes/helm/thirdeye/templates/_helpers.tpl
+++ b/kubernetes/helm/thirdeye/templates/_helpers.tpl
@@ -115,17 +115,3 @@ The name of the thirdeye scheduler (backend with special detector.yml) headless
{{- define "thirdeye.scheduler.headless" -}}
{{- printf "%s-headless" (include "thirdeye.scheduler.fullname" .) | trunc 63 | trimSuffix "-" -}}
{{- end -}}
-
-{{/*
- Create a default fully qualified traefik name.
- We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
-*/}}
-{{- define "thirdeye.traefik.fullname" -}}
-{{- if .Values.traefik.fullnameOverride -}}
-{{- .Values.traefik.fullnameOverride | trunc -63 | trimSuffix "-" -}}
-{{- else -}}
-{{- $name := default "traefik" .Values.traefik.nameOverride -}}
-{{- printf "%s-%s" .Release.Name $name | trunc -63 | trimSuffix "-" -}}
-{{- end -}}
-{{- end -}}
-
diff --git a/kubernetes/helm/thirdeye/templates/frontend/ingress.yaml b/kubernetes/helm/thirdeye/templates/frontend/ingress.yaml
deleted file mode 100644
index 462bb29..0000000
--- a/kubernetes/helm/thirdeye/templates/frontend/ingress.yaml
+++ /dev/null
@@ -1,14 +0,0 @@
-{{- if .Values.traefik.enabled -}}
-kind: Ingress
-apiVersion: extensions/v1beta1
-metadata:
- name: {{ printf "%s-%s" (include "thirdeye.traefik.fullname" . ) "thirdeye" | trunc -63 }}
-spec:
- rules:
- - host: {{ .Release.Name }}.{{ .Release.Namespace }}.{{ required "domain is required." .Values.domain }}
- http:
- paths:
- - backend:
- serviceName: {{ include "thirdeye.frontend.headless" . }}
- servicePort: {{ .Values.frontend.port }}
-{{- end }}
diff --git a/kubernetes/helm/thirdeye/values.yaml b/kubernetes/helm/thirdeye/values.yaml
index 58d0a9f..d2ecd44 100644
--- a/kubernetes/helm/thirdeye/values.yaml
+++ b/kubernetes/helm/thirdeye/values.yaml
@@ -68,8 +68,3 @@ persistence:
accessMode: ReadWriteOnce
size: 4G
storageClass: ""
-
-
-traefik:
- enabled: false
-
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org