[GitHub] [openwhisk] jiangpengcheng commented on a change in pull request #4632: Activation Persister Service

[GitBox <gi...@apache.org>]

jiangpengcheng commented on a change in pull request #4632: Activation Persister Service
URL: https://github.com/apache/openwhisk/pull/4632#discussion_r327483522
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
 ##########
 @@ -195,9 +197,14 @@ class InvokerReactive(
   }
 
   /** Stores an activation in the database. */
-  private val store = (tid: TransactionId, activation: WhiskActivation, context: UserContext) => {
-    implicit val transid: TransactionId = tid
-    activationStore.storeAfterCheck(activation, context)(tid, notifier = None)
+  private val store = if (activationStorageConfig.activationStoreEnabled) {
+    (tid: TransactionId, activation: WhiskActivation, context: UserContext) =>
+      {
 
 Review comment:
   I'm getting a little confused, if we set `activationStoreEnabled` to `false`, the `store` will do nothing here(code will not jump to `KafkaActivationStore.store` neither), then how can `activations` be sent to kafka? I see that only blocking activations result will be sent to `completedN` topic, but for non-blocking activations, they will be missing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services