You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 03:19:44 UTC
[GitHub] [pulsar] labuladong opened a new issue, #17501: [Doc] Add prompt to users who are reading old version doc
labuladong opened a new issue, #17501:
URL: https://github.com/apache/pulsar/issues/17501
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### What issue do you find in Pulsar docs?
There is no prompt if users read the old version document.
<img width="1135" alt="image" src="https://user-images.githubusercontent.com/37220920/188780881-7a5221ed-1795-41a6-bfbc-d542c8bc1358.png">
Users may be confused if they read the wrong version doc.
### What is your suggestion?
Remind users that this version is not the newest, like this:
### Any reference?
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1240154113
@urfreespace Thanks! I added some comments after merge for following improves :)
This issue can be closed as completed, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
labuladong commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1240155118
@urfreespace Looks great, thanks! I'll close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
momo-jun commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1240253303
@urfreespace thanks for the quick implementation!
Only one concern on the wording - actually, we maintain the last four minor versions, e.g., 2.8.x, 2.9.x, and 2.10.x. Shall we differentiate that in the prompt? @Anonymitaet any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] urfreespace commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
urfreespace commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1255657390
@labuladong fixed; pls close this issue after you checked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1250712677
@labuladong https://github.com/apache/pulsar-site/pull/207#issuecomment-1250665086 is the proposed solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
labuladong commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1255697408
Thanks for your work, it looks good to me. I'll close this issue : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1240322363
@momo-jun that's already done, you can check the website
2.8.x
<img width="1153" alt="image" src="https://user-images.githubusercontent.com/50226895/189058748-9fa0b181-e8d2-4534-a85c-345c15745a99.png">
2.9.x
<img width="1164" alt="image" src="https://user-images.githubusercontent.com/50226895/189058800-8680f532-b80d-4f1f-a9f9-c808d3ac79a4.png">
2.10.x
No tip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1238911432
Thanks! @labuladong
This feature is supported by Docusaurus. Info like below can be added.
<img width="1697" alt="image" src="https://user-images.githubusercontent.com/50226895/188792714-424312cd-ffc1-43b5-93e5-eb40667f204a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
labuladong commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1238862907
cc @tisonkun @Anonymitaet @momo-jun @urfreespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1238913405
+1 Also refer to how Flink displays this infohttps://nightlies.apache.org/flink/flink-docs-release-1.12/:
<img width="1728" alt="image" src="https://user-images.githubusercontent.com/18818196/188793273-32cc40db-7c33-4754-b847-59afc7c380a5.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1240326746
@urfreespace thanks for your contribution!
One question:
<img width="1343" alt="image" src="https://user-images.githubusercontent.com/50226895/189060046-0a51ec92-0d48-44c5-ae0e-d5b2ff465866.png">
Reasons: https://github.com/apache/pulsar-site/pull/176#issuecomment-1239013191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong closed issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
labuladong closed issue #17501: [Doc] Add prompt to users who are reading old version doc
URL: https://github.com/apache/pulsar/issues/17501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
labuladong commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1248899561
I found that only versions in sidebar have the banner, but many old versions in [other version page](https://pulsar.apache.org/versions) do not have the banner. For example [Pulsar V2.6.3](https://pulsar.apache.org/docs/2.6.3/):
Reopen this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] urfreespace commented on issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
urfreespace commented on issue #17501:
URL: https://github.com/apache/pulsar/issues/17501#issuecomment-1240148703
Done, screenshot here:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong closed issue #17501: [Doc] Add prompt to users who are reading old version doc
Posted by GitBox <gi...@apache.org>.
labuladong closed issue #17501: [Doc] Add prompt to users who are reading old version doc
URL: https://github.com/apache/pulsar/issues/17501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org