[GitHub] [superset] jayakrishnankk commented on a change in pull request #18133: chore: migrating storybook jsx to typescript #18100

[GitBox <gi...@apache.org>]

jayakrishnankk commented on a change in pull request #18133:
URL: https://github.com/apache/superset/pull/18133#discussion_r790390383



##########
File path: superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-time-format/TimeFormatStories.tsx
##########
@@ -17,30 +17,25 @@
  * under the License.
  */
 
-/* eslint-disable jsx-a11y/label-has-associated-control */
 import React from 'react';
 import { formatTime } from '@superset-ui/core';
 
-const propTypes = {};
-const defaultProps = {};
-
 class TimeFormatValidator extends React.PureComponent {
+  state: { formatString: string; testValues: any[] } = {

Review comment:
       This typing do suggest another change in the file
   `superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts::formatTime() method`
   
   `value: Date | number | null | undefined, --> value: Date | null | undefined,` Hope it is okay to change this. Functionally it seem to work. So making that change also.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org