[jira] [Commented] (ZOOKEEPER-1982) Refactor (touch|add)Session in SessionTrackerImpl.java

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070876#comment-14070876 ] 

Hadoop QA commented on ZOOKEEPER-1982:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12657175/ZOOKEEPER-1982.patch
  against trunk revision 1612458.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2214//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2214//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2214//console

This message is automatically generated.

> Refactor (touch|add)Session in SessionTrackerImpl.java
> ------------------------------------------------------
>
>                 Key: ZOOKEEPER-1982
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1982
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1982.patch
>
>
> This JIRA extends the idea of ZOOKEEPER-1978.
> Besides refactoring get-put operations of concurrentMap in addSession method, addSession also calls touchSession which repeatedly checks if session existed. So it would be nice for refactor. Refactoring the second issue is relevant to ZOOKEEPER-1978. So I create a this JIRA to fix both.



--
This message was sent by Atlassian JIRA
(v6.2#6252)