You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by jo...@apache.org on 2019/12/10 02:45:30 UTC

[incubator-dolphinscheduler] branch dev-db updated: "v-for" add key (#1419)

This is an automated email from the ASF dual-hosted git repository.

journey pushed a commit to branch dev-db
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev-db by this push:
     new 0a87c21  "v-for" add key (#1419)
0a87c21 is described below

commit 0a87c21656b29b9599bb94e46c7f6544dd085cd5
Author: break60 <79...@qq.com>
AuthorDate: Tue Dec 10 10:45:23 2019 +0800

    "v-for" add key (#1419)
---
 .../src/js/conf/home/pages/dag/_source/variable/variablesView.vue  | 7 ++++---
 .../src/js/conf/home/pages/monitor/pages/servers/db.vue            | 2 +-
 .../src/js/conf/home/pages/monitor/pages/servers/master.vue        | 2 +-
 .../src/js/conf/home/pages/monitor/pages/servers/worker.vue        | 2 +-
 .../pages/projects/pages/definition/pages/list/_source/email.vue   | 4 ++--
 .../conf/home/pages/projects/pages/definition/pages/tree/index.vue | 4 ++--
 .../conf/home/pages/projects/pages/instance/pages/gantt/index.vue  | 2 +-
 .../src/js/module/components/secondaryMenu/secondaryMenu.vue       | 2 +-
 dolphinscheduler-ui/src/js/module/components/transfer/transfer.vue | 4 ++--
 9 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/variable/variablesView.vue b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/variable/variablesView.vue
index 369e0cb..1fe4bff 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/variable/variablesView.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/variable/variablesView.vue
@@ -25,6 +25,7 @@
                     size="xsmall"
                     type="ghost"
                     @click="_copy('gbudp-' + $index)"
+                    :key="$index"
                     :data-clipboard-text="item.prop + ' = ' +item.value"
                     :class="'gbudp-' + $index">
               <b style="color: #2A455B;">{{item.prop}}</b> = {{item.value}}
@@ -38,12 +39,12 @@
           &nbsp;
         </div>
       </div>
-      <div class="list list-t" v-for="(item,key,$index) in list.localParams">
+      <div class="list list-t" v-for="(item,key,$index) in list.localParams" :key="$index">
         <div class="task-name">Task({{$index}}):{{key}}</div>
         <div class="var-cont" v-if="item.localParamsList.length">
           <template v-for="(el,index) in item.localParamsList">
-            <x-button size="xsmall" type="ghost" @click="_copy('copy-part-' + index)" :data-clipboard-text="_rtClipboard(el,item.taskType)" :class="'copy-part-' + index">
-              <span v-for="(e,k,i) in el">
+            <x-button size="xsmall" type="ghost" :key="index" @click="_copy('copy-part-' + index)" :data-clipboard-text="_rtClipboard(el,item.taskType)" :class="'copy-part-' + index">
+              <span v-for="(e,k,i) in el" :key="i">
                 <template v-if="item.taskType === 'SQL' || item.taskType === 'PROCEDURE'">
                   <template v-if="(k !== 'direct' && k !== 'type')">
                     <b style="color: #2A455B;">{{k}}</b> = {{e}}
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/db.vue b/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/db.vue
index 363b37b..8147251 100755
--- a/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/db.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/db.vue
@@ -17,7 +17,7 @@
 <template>
   <div>
     <div class="servers-wrapper mysql-model content-wrap" v-show="mysqlList.length">
-      <div class="row" v-for="(item,$index) in mysqlList">
+      <div class="row" v-for="(item,$index) in mysqlList" :key="$index">
         <div class="col-md-12">
           <div class="db-title">
             <span>{{item.dbType+$t('Manage')}}</span>
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/master.vue b/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/master.vue
index e2a7d0c..bd760d5 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/master.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/master.vue
@@ -18,7 +18,7 @@
   <m-list-construction :title="'Master ' + $t('Manage')">
     <template slot="content">
       <div class="servers-wrapper" v-show="masterList.length">
-        <div class="row-box" v-for="(item,$index) in masterList">
+        <div class="row-box" v-for="(item,$index) in masterList" :key="$index">
           <div class="row-title">
             <div class="left">
               <span class="sp">IP: {{item.host}}</span>
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/worker.vue b/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/worker.vue
index 758dd48..f935628 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/worker.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/worker.vue
@@ -18,7 +18,7 @@
   <m-list-construction :title="'Worker ' + $t('Manage')">
     <template slot="content">
       <div class="servers-wrapper" v-show="workerList.length">
-        <div class="row-box" v-for="(item,$index) in workerList">
+        <div class="row-box" v-for="(item,$index) in workerList" :key="$index">
           <div class="row-title">
             <div class="left">
               <span class="sp">IP: {{item.host}}</span>
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/email.vue b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/email.vue
index 3a1f6d2..ba99b14 100755
--- a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/email.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/email.vue
@@ -17,7 +17,7 @@
 <template>
   <div class="ans-input email-model">
     <div class="clearfix input-element" :class="disabled ? 'disabled' : ''">
-      <span class="tag-wrapper" v-for="(item,$index) in activeList" :class="activeIndex === $index ? 'active' : ''">
+      <span class="tag-wrapper" v-for="(item,$index) in activeList" :key="$index" :class="activeIndex === $index ? 'active' : ''">
         <span class="tag-text">{{item}}</span>
         <i class="remove-tag ans-icon-close" @click.stop="_del($index)" v-if="!disabled"></i>
       </span>
@@ -31,7 +31,7 @@
           <div class="ans-scroller" style=" max-height: 300px;">
             <div class="scroll-area-wrapper scroll-transition">
               <ul class="dropdown-container">
-                <li class="ans-option" v-for="(item,$index) in emailList" @click.stop="_selectEmail($index + 1)">
+                <li class="ans-option" v-for="(item,$index) in emailList" @click.stop="_selectEmail($index + 1)" :key="$index">
                   <span class="default-option-class" :class="index === ($index + 1) ? 'active' : ''">{{item}}</span>
                 </li>
               </ul>
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/tree/index.vue b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/tree/index.vue
index eddc6dc..94b0485 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/tree/index.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/tree/index.vue
@@ -42,7 +42,7 @@
             <a href="javascript:">
               <span>Node Type</span>
             </a>
-            <a href="javascript:" v-for="(k,v) in tasksType">
+            <a href="javascript:" v-for="(k,v) in tasksType" :key="v">
               <i class="fa fa-circle" :style="{color:k.color}"></i>
               <span>{{v}}</span>
             </a>
@@ -51,7 +51,7 @@
             <a href="javascript:">
               <span>{{$t('Task Status')}}</span>
             </a>
-            <a href="javascript:" v-for="(item) in tasksState">
+            <a href="javascript:" v-for="(item) in tasksState" :key="item.id">
               <i class="fa fa-square" :style="{color:item.color}"></i>
               <span>{{item.desc}}</span>
             </a>
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue
index 0927a6a..8260998 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/gantt/index.vue
@@ -23,7 +23,7 @@
             <a href="javascript:">
               <span>{{$t('Task Status')}}</span>
             </a>
-            <a href="javascript:" v-for="(item) in tasksState">
+            <a href="javascript:" v-for="(item) in tasksState" :key="item.id">
               <i class="fa fa-square" :style="{color:item.color}"></i>
               <span>{{item.desc}}</span>
             </a>
diff --git a/dolphinscheduler-ui/src/js/module/components/secondaryMenu/secondaryMenu.vue b/dolphinscheduler-ui/src/js/module/components/secondaryMenu/secondaryMenu.vue
index edd6bfd..8c09bfb 100644
--- a/dolphinscheduler-ui/src/js/module/components/secondaryMenu/secondaryMenu.vue
+++ b/dolphinscheduler-ui/src/js/module/components/secondaryMenu/secondaryMenu.vue
@@ -44,7 +44,7 @@
         </template>
         <ul v-if="item.isOpen && item.children.length">
           <template v-for="(el,index) in item.children">
-            <router-link :to="{ name: el.path}" tag="li" active-class="active" v-if="el.disabled">
+            <router-link :to="{ name: el.path}" tag="li" active-class="active" v-if="el.disabled" :key="index">
               <span>{{el.name}}</span>
             </router-link>
           </template>
diff --git a/dolphinscheduler-ui/src/js/module/components/transfer/transfer.vue b/dolphinscheduler-ui/src/js/module/components/transfer/transfer.vue
index b1d871d..97780b4 100644
--- a/dolphinscheduler-ui/src/js/module/components/transfer/transfer.vue
+++ b/dolphinscheduler-ui/src/js/module/components/transfer/transfer.vue
@@ -36,7 +36,7 @@
           </div>-->
           <div class="scrollbar tf-content">
             <ul>
-              <li v-for="(item,$index) in sourceList" :key="item.id" @click="_ckSource(item)">
+              <li v-for="(item,$index) in sourceList" :key="$index" @click="_ckSource(item)">
                 <span>{{item.name}}</span>
                 <a href="javascript:"></a>
               </li>
@@ -62,7 +62,7 @@
           </div>-->
           <div class="scrollbar tf-content">
             <ul>
-              <li v-for="(item,$index) in targetList" :key="item.id" @click="_ckTarget(item)"><span>{{item.name}}</span></li>
+              <li v-for="(item,$index) in targetList" :key="$index" @click="_ckTarget(item)"><span>{{item.name}}</span></li>
             </ul>
           </div>
         </div>