You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/04/06 13:02:46 UTC

Review Request 58232: Hive view holds the operational logs open and also fills /tmp

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58232/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20690
    https://issues.apache.org/jira/browse/AMBARI-20690


Repository: ambari


Description
-------

sync connections were not getting closed after 10 mins window of inactivity. 
removed the incorrect call to stop scheduler


Diffs
-----

  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java 36bc430b7f 
  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java 997c28aab3 
  contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java 98e60f2610 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java 384b7982bd 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java f93ecbffb3 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java f751d8f54b 


Diff: https://reviews.apache.org/r/58232/diff/1/


Testing
-------

manual testing done.


Thanks,

Nitiraj Rathore


Re: Review Request 58232: Hive view holds the operational logs open and also fills /tmp

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58232/#review171204
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On April 6, 2017, 1:02 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58232/
> -----------------------------------------------------------
> 
> (Updated April 6, 2017, 1:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20690
>     https://issues.apache.org/jira/browse/AMBARI-20690
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> sync connections were not getting closed after 10 mins window of inactivity. 
> removed the incorrect call to stop scheduler
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java 36bc430b7f 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java 997c28aab3 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java 98e60f2610 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java 384b7982bd 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java f93ecbffb3 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java f751d8f54b 
> 
> 
> Diff: https://reviews.apache.org/r/58232/diff/1/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 58232: Hive view holds the operational logs open and also fills /tmp

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58232/#review172595
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On April 6, 2017, 1:02 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58232/
> -----------------------------------------------------------
> 
> (Updated April 6, 2017, 1:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20690
>     https://issues.apache.org/jira/browse/AMBARI-20690
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> sync connections were not getting closed after 10 mins window of inactivity. 
> removed the incorrect call to stop scheduler
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java 36bc430b7f 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java 997c28aab3 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java 98e60f2610 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java 384b7982bd 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java f93ecbffb3 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java f751d8f54b 
> 
> 
> Diff: https://reviews.apache.org/r/58232/diff/1/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 58232: Hive view holds the operational logs open and also fills /tmp

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58232/#review172594
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On April 6, 2017, 1:02 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58232/
> -----------------------------------------------------------
> 
> (Updated April 6, 2017, 1:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20690
>     https://issues.apache.org/jira/browse/AMBARI-20690
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> sync connections were not getting closed after 10 mins window of inactivity. 
> removed the incorrect call to stop scheduler
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java 36bc430b7f 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java 997c28aab3 
>   contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java 98e60f2610 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java 384b7982bd 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java f93ecbffb3 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java f751d8f54b 
> 
> 
> Diff: https://reviews.apache.org/r/58232/diff/1/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>