You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Jonathan Moore (JIRA)" <ji...@apache.org> on 2010/09/21 21:00:38 UTC

[jira] Created: (HTTPCLIENT-999) need tests to guarantee transparency of caching module on end-to-end headers

need tests to guarantee transparency of caching module on end-to-end headers
----------------------------------------------------------------------------

                 Key: HTTPCLIENT-999
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-999
             Project: HttpComponents HttpClient
          Issue Type: Test
          Components: Cache
    Affects Versions: 4.1 Alpha2
            Reporter: Jonathan Moore


A transparent proxy SHOULD NOT modify an end-to-end header unless the definition of that header requires or specifically allows that."

http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.5.2

This is already true of our implementation, but we should have tests to preserve that behavior.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Updated: (HTTPCLIENT-999) need tests to guarantee transparency of caching module on end-to-end headers

Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Moore updated HTTPCLIENT-999:
--------------------------------------

    Description: 
"A transparent proxy SHOULD NOT modify an end-to-end header unless the definition of that header requires or specifically allows that."

http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.5.2

This is already true of our implementation, but we should have tests to preserve that behavior.


  was:
A transparent proxy SHOULD NOT modify an end-to-end header unless the definition of that header requires or specifically allows that."

http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.5.2

This is already true of our implementation, but we should have tests to preserve that behavior.



> need tests to guarantee transparency of caching module on end-to-end headers
> ----------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-999
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-999
>             Project: HttpComponents HttpClient
>          Issue Type: Test
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Jonathan Moore
>         Attachments: e2e-header-tests.patch
>
>
> "A transparent proxy SHOULD NOT modify an end-to-end header unless the definition of that header requires or specifically allows that."
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.5.2
> This is already true of our implementation, but we should have tests to preserve that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Updated: (HTTPCLIENT-999) need tests to guarantee transparency of caching module on end-to-end headers

Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Moore updated HTTPCLIENT-999:
--------------------------------------

    Attachment: e2e-header-tests.patch

This patch adds tests to TestProtocolRecommendations to guarantee end-to-end header behavior. Note that these only test "single-value" headers (like Date) and not to "multi-value" headers (like Cache-Control), because we already have tests in TestProtocolRequirements that govern keeping multi-valued end-to-end headers in the same order (which is a MUST for a transparent proxy).

This patch is contributed to the ASF with the permission of my employer.


> need tests to guarantee transparency of caching module on end-to-end headers
> ----------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-999
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-999
>             Project: HttpComponents HttpClient
>          Issue Type: Test
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Jonathan Moore
>         Attachments: e2e-header-tests.patch
>
>
> A transparent proxy SHOULD NOT modify an end-to-end header unless the definition of that header requires or specifically allows that."
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.5.2
> This is already true of our implementation, but we should have tests to preserve that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Resolved: (HTTPCLIENT-999) need tests to guarantee transparency of caching module on end-to-end headers

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-999.
------------------------------------------

    Fix Version/s: 4.1 Alpha3
       Resolution: Fixed

Patch checked in. Many thanks, Jon

Oleg

> need tests to guarantee transparency of caching module on end-to-end headers
> ----------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-999
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-999
>             Project: HttpComponents HttpClient
>          Issue Type: Test
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Jonathan Moore
>             Fix For: 4.1 Alpha3
>
>         Attachments: e2e-header-tests.patch
>
>
> "A transparent proxy SHOULD NOT modify an end-to-end header unless the definition of that header requires or specifically allows that."
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.5.2
> This is already true of our implementation, but we should have tests to preserve that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org