[GitHub] rlevas commented on issue #56: KNOX-1756 - Knox Gateway TLS Keystore and Alias Should be Configurable

[GitBox <gi...@apache.org>]

rlevas commented on issue #56: KNOX-1756 - Knox Gateway TLS Keystore and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/56#issuecomment-466524574
 
 
   > For the `./bin/knoxcli.sh create-cert`, I was using a self signed certificate for testing and create-cert overwrites the existing certificate if it is self signed. Based on rereading the PR this is expected behavior.
   > 
   > I guess I was expecting to have to force to overwrite the existing certificate since it was a certificate that I had created.
   
   Would you like this behavior changed to require `--force` if the entry exists in the keystore?  However I think overwriting was the behavior before the changes in this patch. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services