You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/11 10:32:27 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #219: [YUNIKORN-352] - fixed max resource check and behavioural change
codecov[bot] edited a comment on pull request #219:
URL: https://github.com/apache/incubator-yunikorn-core/pull/219#issuecomment-713539637
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=h1) Report
> Merging [#219](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=desc) (d638ff3) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/01f5288eb5931a16834e0402af9efb308f946ad4?el=desc) (01f5288) will **decrease** coverage by `2.19%`.
> The diff coverage is `74.24%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 63.12% 60.92% -2.20%
==========================================
Files 59 67 +8
Lines 4879 5815 +936
==========================================
+ Hits 3080 3543 +463
- Misses 1657 2121 +464
- Partials 142 151 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/common/resources/resources.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcmVzb3VyY2VzLmdv) | `91.91% <21.05%> (-5.60%)` | :arrow_down: |
| [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `89.23% <95.74%> (+2.22%)` | :arrow_up: |
| [pkg/common/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy5nbw==) | `66.66% <0.00%> (-5.21%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `53.89% <0.00%> (-1.19%)` | :arrow_down: |
| [pkg/scheduler/preemptor.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wcmVlbXB0b3IuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/node\_iterator.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9ub2RlX2l0ZXJhdG9yLmdv) | `100.00% <0.00%> (ø)` | |
| [pkg/scheduler/partition\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb25fbWFuYWdlci5nbw==) | `0.00% <0.00%> (ø)` | |
| ... and [44 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=footer). Last update [01f5288...572c116](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org