You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/02/09 09:55:36 UTC

[GitHub] zeppelin pull request #2000: [gh-pages] update contribution/webapplication.h...

GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2000

    [gh-pages] update contribution/webapplication.html

    ### What is this PR for?
    This PR is for matching current web environment. 
    I changed `dev mode` part from `./grunt serve` to `yarn run dev` and fixed some typo.
    
    ### What type of PR is it?
    [ Documentation]
    
    ### What is the Jira issue?
    * None
    
    ### How should this be tested?
    * build `gh-pages` branch and then check [webapplication.html](http://localhost:4000/contribution/webapplication.html) page.
    
    ### Screenshots (if appropriate)
    ![image](https://cloud.githubusercontent.com/assets/8110458/22778139/2d826150-eef9-11e6-80fe-d06048982c59.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin gh_contribute_web_dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2000.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2000
    
----
commit e0c08cd083575b744388fa005d431563d6bb02f6
Author: soralee <so...@zepl.com>
Date:   2017-02-09T09:40:59Z

    update contribute/webapplication.html

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2000: [gh-pages] update contribution/webapplication.h...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2000


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2000
  
    I found another typo in [contribution/zeppelinweb/goodPracticeGuide04.html](http://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide04.html). Could you fix this one as well? It should be `ng-bing` -> `ng-bind` :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2000
  
    Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2000
  
    Thanks for review! @AhyoungRyu @1ambda 
    I'll update this soon!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2000
  
    @AhyoungRyu @1ambda Could you review this, please whether I missed something or not?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2000
  
    Hi~ @AhyoungRyu @1ambda 
    I updated this as your comment! 
    Thanks for that could you review again, please? :smiley: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2000
  
    Hi @soralee :)
    
    I would like to suggest using `'ngInject'l` instead of `$inject = ['$location'];` as like https://github.com/apache/zeppelin/pull/1994
    
    > http://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2000
  
    Looks nice :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2000
  
    Merge into `gh-pages` if there are no more comments. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---