You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/29 06:20:20 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #242: [YUNIKORN-461] remove allocations list from partition
codecov[bot] commented on pull request #242:
URL: https://github.com/apache/incubator-yunikorn-core/pull/242#issuecomment-769604051
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242?src=pr&el=h1) Report
> Merging [#242](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242?src=pr&el=desc) (71880c9) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/78bf4f68470987c110399fafa1671b3ffc85a358?el=desc) (78bf4f6) will **increase** coverage by `0.48%`.
> The diff coverage is `67.74%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 62.98% 63.46% +0.48%
==========================================
Files 60 60
Lines 5203 5220 +17
==========================================
+ Hits 3277 3313 +36
+ Misses 1764 1747 -17
+ Partials 162 160 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `66.04% <67.74%> (+3.25%)` | :arrow_up: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `48.90% <0.00%> (+0.21%)` | :arrow_up: |
| [pkg/scheduler/objects/application\_state.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `95.77% <0.00%> (+0.94%)` | :arrow_up: |
| [pkg/scheduler/partition\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb25fbWFuYWdlci5nbw==) | `20.00% <0.00%> (+4.00%)` | :arrow_up: |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242/diff?src=pr&el=tree#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `100.00% <0.00%> (+11.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242?src=pr&el=footer). Last update [78bf4f6...71880c9](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/242?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org