You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2015/04/23 18:40:38 UTC
[jira] [Commented] (HIVE-8343) Return value from
BlockingQueue.offer() is not checked in DynamicPartitionPruner
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509320#comment-14509320 ]
Ted Yu commented on HIVE-8343:
------------------------------
lgtm
> Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner
> --------------------------------------------------------------------------------
>
> Key: HIVE-8343
> URL: https://issues.apache.org/jira/browse/HIVE-8343
> Project: Hive
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: JongWon Park
> Priority: Minor
> Attachments: HIVE-8343.patch
>
>
> In addEvent() and processVertex(), there is call such as the following:
> {code}
> queue.offer(event);
> {code}
> The return value should be checked. If false is returned, event would not have been queued.
> Take a look at line 328 in:
> http://fuseyism.com/classpath/doc/java/util/concurrent/LinkedBlockingQueue-source.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)