You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/01 11:32:15 UTC
[GitHub] [iotdb] RYH61 commented on a diff in pull request #6854: [IOTDB-4007]Support multiple paths in privilege control
RYH61 commented on code in PR #6854:
URL: https://github.com/apache/iotdb/pull/6854#discussion_r934426836
##########
thrift-confignode/src/main/thrift/confignode.thrift:
##########
@@ -174,7 +174,7 @@ struct TAuthorizerReq {
4: required string password
5: required string newPassword
6: required set<i32> permissions
- 7: required string nodeName
+ 7: required list<string> nodeName
Review Comment:
```suggestion
7: required list<string> nodeNameList
```
##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/AuthorInfo.java:
##########
@@ -145,7 +146,7 @@ public TSStatus authorNonQuery(AuthorPlan authorPlan) {
String password = authorPlan.getPassword();
String newPassword = authorPlan.getNewPassword();
Set<Integer> permissions = authorPlan.getPermissions();
- String nodeName = authorPlan.getNodeName();
+ List<String> nodeName = authorPlan.getNodeNameList();
Review Comment:
```suggestion
List<String> nodeNameList = authorPlan.getNodeNameList();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org