You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/19 09:17:46 UTC

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9200: MINOR: mirror integration tests should not call System.exit

rajinisivaram commented on a change in pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#discussion_r472885774



##########
File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##########
@@ -185,10 +192,10 @@ public void close() {
         deleteAllTopics(backup.kafka());
         primary.stop();
         backup.stop();
+        assertFalse(exited.get());
+        Exit.resetExitProcedure();

Review comment:
       I am guessing we ran into an issue because of exit, so perhaps this reset ought to be in a finally block?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org