[jira] [Commented] (TAJO-279) Improving the query_executor page of web UI

["Hyunsik Choi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802610#comment-13802610 ] 

Hyunsik Choi commented on TAJO-279:
-----------------------------------

The patch looks great for me. Thank you for nice contribution. There are a couple of issues that we need to discuss.

Firstly, I wonder whether 'Download to CSV feature' reads data on HDFS or only outputs the data of HTML page? Unless the output table is explicitly given, the result data stored on HDFS will be automatically removed after a while. If Download feature is based on HDFS, it is only available for a while. Next and previous buttons also have the same problem. So, I think that Tajo web UI should show some part whose volume can be shown in the web page in the case where output data is too large.

Second, google js works only online. However, The environments where Tajo usually is used have local networks that cannot access to Internet. So, the chart included in the patch won't work in those environments.

When it comes to code, there are some bugs. 'Download feature' leads to wrong results. I've just experienced the number of results are fewer than that of the correct result. I'm expecting that the first row is omitted.

In addition, two jsapi.js files are included in the patch.
{code}
#	tajo-core/tajo-core-backend/src/main/resources/webapps/static/js/jsapi.js
#	tajo-core/tajo-core-backend/src/main/resources/webapps/static/jsapi.js
{code}

Thank you for your contribution.

> Improving the query_executor page of web UI
> -------------------------------------------
>
>                 Key: TAJO-279
>                 URL: https://issues.apache.org/jira/browse/TAJO-279
>             Project: Tajo
>          Issue Type: Improvement
>          Components: web UI
>            Reporter: Wan Heo
>            Assignee: Wan Heo
>             Fix For: 0.3-incubating
>
>         Attachments: screenshot.png, TAJO-279.patch
>
>
> * Add "Paging" to the result view.
> ** If there are too many results, the result view occupies too much space in the current implementation. Furthermore, memory overflow might be occurred in the browsers. Now, users read results more conveniently.
> * Add "CSV export" to the result view.
> ** Users can download the results in CSV file format.
> * Add "Graph function".
> ** Users can view a graph from the results.
> ** Bar, Pie, Line and Map types are supported in this patch.



--
This message was sent by Atlassian JIRA
(v6.1#6144)