You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/05/25 20:23:00 UTC

[jira] [Commented] (ARROW-7784) [C++] diff.cc is extremely slow to compile

    [ https://issues.apache.org/jira/browse/ARROW-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116238#comment-17116238 ] 

Wes McKinney commented on ARROW-7784:
-------------------------------------

"QuadraticSpaceMyersDiff" is being instantiated for every Arrow type. Given that this code is not performance sensitive, I would suggest refactoring this code to only instantiate a single implementation of the Diff algorithm (rather than 25+ instantiations) and where relevant introduce a virtual interface for interacting with values in different-type arrays. 

> [C++] diff.cc is extremely slow to compile
> ------------------------------------------
>
>                 Key: ARROW-7784
>                 URL: https://issues.apache.org/jira/browse/ARROW-7784
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Antoine Pitrou
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> This comes up especially when doing an optimized build. {{diff.cc}} is always enabled even if all components are disabled, and it takes multiple seconds to compile. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)