[GitHub] [hive] szlta commented on pull request #4291: Hive-27306: port iceberg catalog changes

["szlta (via GitHub)" <gi...@apache.org>]

szlta commented on PR #4291:
URL: https://github.com/apache/hive/pull/4291#issuecomment-1541551847

   > > First of all, I have a question about the namings: do you know why Iceberg and Hive has different naming for the class using for locking? In Hive, it is called `HiveCommitLog` and in Iceberg, it is `HiveMetastoreLock`.
   > 
   > It was after my time, but I expect that @szlta give up on getting his refactor into Iceberg, but needed it in Hive.
   
   Yup, I did that refactor with https://github.com/apache/hive/commit/2e916a3ec26a6d12653c89ad445fed91e1ba0cde so that we can acquire the commit lock from `HiveIcebergMetaHook` too. The reason why it was not ported to Iceberg was that Iceberg was depending on an old Hive version where some of the hooks (especially for alter_table) didn't exist yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org