[GitHub] [airflow] potiuk commented on a change in pull request #9333: Add HashiCorp Vault Hook (split-out from Vault secret backend)

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #9333:
URL: https://github.com/apache/airflow/pull/9333#discussion_r441452600



##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -50,42 +46,44 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin):
     would be accessible if you provide ``{"connections_path": "connections"}`` and request
     conn_id ``smtp_default``.
 
-    :param connections_path: Specifies the path of the secret to read to get Connections.
-        (default: 'connections')
+    :param connections_path: Specifies the path of the secret to read to get Connections
+        (default: 'connections').
     :type connections_path: str
-    :param variables_path: Specifies the path of the secret to read to get Variables.
-        (default: 'variables')
+    :param variables_path: Specifies the path of the secret to read to get Variables
+        (default: 'variables').
     :type variables_path: str
     :param url: Base URL for the Vault instance being addressed.
     :type url: str
-    :param auth_type: Authentication Type for Vault (one of 'token', 'ldap', 'userpass', 'approle',
-        'github', 'gcp', 'kubernetes'). Default is ``token``.
+    :param auth_type: Authentication Type for Vault. Default is ``token``. Available values are in
+        :py:const:`airflow.providers.hashicorp.hooks.vault.VALID_AUTH_TYPES`.

Review comment:
       Yep. No enum here is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org