[GitHub] [spark] amaliujia commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018578346


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
   // Required. The input relation.
   Relation input = 1;
 
-  // Required.
+  // Optional.
   //
   // The number of columns of the input relation must be equal to the length
   // of this field. If this is not true, an exception will be returned.
+  //
+  // This field does not co-exist with the field `rename_columns_map`.

Review Comment:
   I thinks it will face the same thing as https://github.com/apache/spark/pull/38578#discussion_r1017875279 if use oneof. In that case it would be better to just split to have two independent messages. 
   
   Maybe ENUM will be better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org