You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2012/09/19 09:40:07 UTC
[jira] [Created] (GIRAPH-331) ReviewBoard post-review config
Nitay Joffe created GIRAPH-331:
----------------------------------
Summary: ReviewBoard post-review config
Key: GIRAPH-331
URL: https://issues.apache.org/jira/browse/GIRAPH-331
Project: Giraph
Issue Type: Improvement
Reporter: Nitay Joffe
Priority: Trivial
Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-331) ReviewBoard post-review config
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459473#comment-13459473 ]
Hudson commented on GIRAPH-331:
-------------------------------
Integrated in Giraph-trunk-Commit #200 (See [https://builds.apache.org/job/Giraph-trunk-Commit/200/])
GIRAPH-331: ReviewBoard post-review config. (nitayj via aching) (Revision 1387919)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387919
Files :
* /giraph/trunk/.reviewboardrc
* /giraph/trunk/CHANGELOG
* /giraph/trunk/pom.xml
> ReviewBoard post-review config
> ------------------------------
>
> Key: GIRAPH-331
> URL: https://issues.apache.org/jira/browse/GIRAPH-331
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Attachments: GIRAPH-331.txt, GIRAPH-331.txt
>
>
> Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-331) ReviewBoard post-review config
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-331:
-------------------------------
Assignee: Nitay Joffe
> ReviewBoard post-review config
> ------------------------------
>
> Key: GIRAPH-331
> URL: https://issues.apache.org/jira/browse/GIRAPH-331
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Attachments: GIRAPH-331.txt
>
>
> Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-331) ReviewBoard post-review config
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458962#comment-13458962 ]
Eli Reisman commented on GIRAPH-331:
------------------------------------
I like this idea. When you add a config file like this to the code is there anything that needs to be added to the POM.XML or ...?
> ReviewBoard post-review config
> ------------------------------
>
> Key: GIRAPH-331
> URL: https://issues.apache.org/jira/browse/GIRAPH-331
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Trivial
> Attachments: GIRAPH-331.txt
>
>
> Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-331) ReviewBoard post-review config
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-331:
-------------------------------
Attachment: GIRAPH-331.txt
Oh I see, yes it needs the rat excludes. I was confused at first because I kept running mvn rat:check and I would get tons of errors, and only realized later that running mvn org.apache.rat:apache-rat-plugin:check is different (that one actually looks at the pom.xml and uses it). ANyways this passes mvn clean verify for me now.
> ReviewBoard post-review config
> ------------------------------
>
> Key: GIRAPH-331
> URL: https://issues.apache.org/jira/browse/GIRAPH-331
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Attachments: GIRAPH-331.txt, GIRAPH-331.txt
>
>
> Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-331) ReviewBoard post-review config
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-331:
-------------------------------
Attachment: GIRAPH-331.txt
> ReviewBoard post-review config
> ------------------------------
>
> Key: GIRAPH-331
> URL: https://issues.apache.org/jira/browse/GIRAPH-331
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Trivial
> Attachments: GIRAPH-331.txt
>
>
> Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-331) ReviewBoard post-review config
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459471#comment-13459471 ]
Avery Ching commented on GIRAPH-331:
------------------------------------
Looks great. +1, committed.
> ReviewBoard post-review config
> ------------------------------
>
> Key: GIRAPH-331
> URL: https://issues.apache.org/jira/browse/GIRAPH-331
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Attachments: GIRAPH-331.txt, GIRAPH-331.txt
>
>
> Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-331) ReviewBoard post-review config
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459037#comment-13459037 ]
Avery Ching commented on GIRAPH-331:
------------------------------------
+1. This is a nice idea.
> ReviewBoard post-review config
> ------------------------------
>
> Key: GIRAPH-331
> URL: https://issues.apache.org/jira/browse/GIRAPH-331
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Trivial
> Attachments: GIRAPH-331.txt
>
>
> Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-331) ReviewBoard post-review config
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458483#comment-13458483 ]
Nitay Joffe commented on GIRAPH-331:
------------------------------------
Here's an example of running "post-review" (no options whatsoever) with this .reviewboardrc: https://reviews.apache.org/r/7164/
> ReviewBoard post-review config
> ------------------------------
>
> Key: GIRAPH-331
> URL: https://issues.apache.org/jira/browse/GIRAPH-331
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Priority: Trivial
> Attachments: GIRAPH-331.txt
>
>
> Config file to make posting diffs to review board easy using post-review tool (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira