You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/11/03 22:53:14 UTC
Re: Review Request 39449: Documented order of includes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39449/#review104983
-----------------------------------------------------------
Ship it!
docs/c++-style-guide.md (line 235)
<https://reviews.apache.org/r/39449/#comment163346>
Could we add that for cpp files the repective .h file should be included first (which is specified in the Google Styleguide but many files ignore this)
docs/c++-style-guide.md (lines 240 - 241)
<https://reviews.apache.org/r/39449/#comment163348>
Add foo.hpp as first include.
docs/c++-style-guide.md (line 251)
<https://reviews.apache.org/r/39449/#comment163344>
Could we add a short comment above every new section describing the representative meaning of each? (e.g. here nested subfolder)
- Joerg Schad
On Oct. 19, 2015, 9:29 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39449/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 9:29 p.m.)
>
>
> Review request for mesos, Marco Massenzio and Michael Park.
>
>
> Bugs: MESOS-2275
> https://issues.apache.org/jira/browse/MESOS-2275
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented order of includes.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad
>
> Diff: https://reviews.apache.org/r/39449/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 39449: Documented order of includes.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Nov. 3, 2015, 10:53 p.m., Joerg Schad wrote:
> > docs/c++-style-guide.md, line 251
> > <https://reviews.apache.org/r/39449/diff/2/?file=1101246#file1101246line251>
> >
> > Could we add a short comment above every new section describing the representative meaning of each? (e.g. here nested subfolder)
IMHO this could get quite redundant if we do this for every source file.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39449/#review104983
-----------------------------------------------------------
On Oct. 19, 2015, 11:29 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39449/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 11:29 p.m.)
>
>
> Review request for mesos, Marco Massenzio and Michael Park.
>
>
> Bugs: MESOS-2275
> https://issues.apache.org/jira/browse/MESOS-2275
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented order of includes.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad
>
> Diff: https://reviews.apache.org/r/39449/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>