You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/08/05 11:54:01 UTC
[GitHub] [hive] zabetak commented on a diff in pull request #3498: HIVE-24483: Bump protobuf version to 3.7.1 (aarch64 support).
zabetak commented on code in PR #3498:
URL: https://github.com/apache/hive/pull/3498#discussion_r938731653
##########
standalone-metastore/metastore-common/pom.xml:
##########
@@ -457,7 +457,7 @@
<goal>run</goal>
</goals>
<configuration>
- <protocArtifact>${protobuf.group}:protoc:${protobuf-exc.version}</protocArtifact>
+ <protocArtifact>com.google.protobuf:protoc:3.21.4</protocArtifact>
Review Comment:
Should we use `${protobuf.version}` instead of hardcoding `3.21.4`?
##########
hbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java:
##########
@@ -26,8 +26,8 @@
import org.apache.hadoop.hbase.KeyValue;
import org.apache.hadoop.hbase.KeyValueUtil;
import org.apache.hadoop.hbase.client.Result;
-import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
-import org.apache.hadoop.hbase.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
Review Comment:
Do we know why these imports changed and point to shaded classes?
##########
hbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java:
##########
@@ -26,8 +26,8 @@
import org.apache.hadoop.hbase.KeyValue;
import org.apache.hadoop.hbase.KeyValueUtil;
import org.apache.hadoop.hbase.client.Result;
-import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
-import org.apache.hadoop.hbase.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
Review Comment:
Do we know why these imports changed and point to shaded classes?
##########
data/files/datasets/src_hbase/load.hive.sql:
##########
@@ -1,3 +1,5 @@
+DROP table if exists src_hbase_tmp;
Review Comment:
Seems reasonable but why we didn't do it before and we need to it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org