You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Dawid Weiss (JIRA)" <ji...@apache.org> on 2012/05/16 23:19:10 UTC
[jira] [Commented] (LUCENE-4054) Overrides of @Before or @After
hooks should cause a test error.
[ https://issues.apache.org/jira/browse/LUCENE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277148#comment-13277148 ]
Dawid Weiss commented on LUCENE-4054:
-------------------------------------
The tests for this should not fire when run in stand-alone mode because this confuses intellij idea. I think a safe bet would be to check if we're a nested class -- if so, don't run any validations.
> Overrides of @Before or @After hooks should cause a test error.
> ---------------------------------------------------------------
>
> Key: LUCENE-4054
> URL: https://issues.apache.org/jira/browse/LUCENE-4054
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: general/build, general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 4.0
>
>
> The only exceptions are setUp/ tearDown methods in LuceneTestCase, which are historically designed for overriding (and for which chaining is verified). Any other override of am instance hook method should just be banned as it is very likely a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org