You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/23 18:36:12 UTC
[GitHub] [airflow] nuclearpinguin opened a new pull request #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
nuclearpinguin opened a new pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245
When running webserver as daemon it can happen that it will not start
due to existing pidfile. This PR improves whole webserver command and adds
pidfile checking.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `61.29%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
- Coverage 86.88% 86.56% -0.33%
==========================================
Files 924 924
Lines 44674 44681 +7
==========================================
- Hits 38816 38677 -139
- Misses 5858 6004 +146
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `58.50% <36.84%> (+2.58%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `79.09% <100.00%> (+2.56%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [9ad1844...cb0ad0c](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `61.29%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
- Coverage 86.88% 86.56% -0.33%
==========================================
Files 924 924
Lines 44674 44681 +7
==========================================
- Hits 38816 38677 -139
- Misses 5858 6004 +146
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `58.50% <36.84%> (+2.58%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `79.09% <100.00%> (+2.56%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [9ad1844...cb0ad0c](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `61.29%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
- Coverage 86.88% 86.56% -0.33%
==========================================
Files 924 924
Lines 44674 44681 +7
==========================================
- Hits 38816 38677 -139
- Misses 5858 6004 +146
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `58.50% <36.84%> (+2.58%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `79.09% <100.00%> (+2.56%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [9ad1844...cb0ad0c](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r382904441
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -263,40 +264,31 @@ def monitor_gunicorn(gunicorn_master_proc):
sys.exit(gunicorn_master_proc.returncode)
if args.daemon:
- base, ext = os.path.splitext(pid)
- ctx = daemon.DaemonContext(
- pidfile=TimeoutPIDLockFile(base + "-monitor" + ext, -1),
- files_preserve=[handle],
- stdout=stdout,
- stderr=stderr,
- signal_map={
- signal.SIGINT: kill_proc,
- signal.SIGTERM: kill_proc
- },
Review comment:
I've moved those to `monitor_gunicorn` to avoid code duplication (we register them in both daemon and not versions).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r370288287
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -263,40 +264,31 @@ def monitor_gunicorn(gunicorn_master_proc):
sys.exit(gunicorn_master_proc.returncode)
if args.daemon:
- base, ext = os.path.splitext(pid)
- ctx = daemon.DaemonContext(
- pidfile=TimeoutPIDLockFile(base + "-monitor" + ext, -1),
- files_preserve=[handle],
- stdout=stdout,
- stderr=stderr,
- signal_map={
- signal.SIGINT: kill_proc,
- signal.SIGTERM: kill_proc
- },
Review comment:
I moved the signal handling to `monitor_gunicorn` function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9e09fa3c94e6bab98d9557ef2c3a341249d5f746?src=pr&el=desc) will **increase** coverage by `53.39%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
===========================================
+ Coverage 32.92% 86.31% +53.39%
===========================================
Files 871 871
Lines 40660 40665 +5
===========================================
+ Hits 13389 35102 +21713
+ Misses 27271 5563 -21708
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `100% <100%> (+56.25%)` | :arrow_up: |
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `57.34% <40%> (+43.43%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-39.44%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `70.21% <0%> (-23.41%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
| ... and [743 more](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [9e09fa3...7cda881](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r395553659
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -195,15 +197,11 @@ def webserver(args):
port=args.port, host=args.hostname,
ssl_context=(ssl_cert, ssl_key) if ssl_cert and ssl_key else None)
else:
- os.environ['SKIP_DAGS_PARSING'] = 'True'
- app = cached_app(None)
- pid, stdout, stderr, log_file = setup_locations(
+ pid_file, stdout, stderr, log_file = setup_locations(
"webserver", args.pid, args.stdout, args.stderr, args.log_file)
- os.environ.pop('SKIP_DAGS_PARSING')
Review comment:
App was unused, but this pre-warms the cache, and makes possible errors get reported earlier (i.e. before demonization) so I am not sure about this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `61.29%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
- Coverage 86.88% 86.56% -0.33%
==========================================
Files 924 924
Lines 44674 44681 +7
==========================================
- Hits 38816 38677 -139
- Misses 5858 6004 +146
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `58.50% <36.84%> (+2.58%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `79.09% <100.00%> (+2.56%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [9ad1844...cb0ad0c](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r370287859
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -195,15 +197,11 @@ def webserver(args):
port=args.port, host=args.hostname,
ssl_context=(ssl_cert, ssl_key) if ssl_cert and ssl_key else None)
else:
- os.environ['SKIP_DAGS_PARSING'] = 'True'
- app = cached_app(None)
- pid, stdout, stderr, log_file = setup_locations(
+ pid_file, stdout, stderr, log_file = setup_locations(
"webserver", args.pid, args.stdout, args.stderr, args.log_file)
- os.environ.pop('SKIP_DAGS_PARSING')
Review comment:
The `app` was unused and I see no reason for those env changes when we remove the app.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r395980614
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -195,15 +197,11 @@ def webserver(args):
port=args.port, host=args.hostname,
ssl_context=(ssl_cert, ssl_key) if ssl_cert and ssl_key else None)
else:
- os.environ['SKIP_DAGS_PARSING'] = 'True'
- app = cached_app(None)
- pid, stdout, stderr, log_file = setup_locations(
+ pid_file, stdout, stderr, log_file = setup_locations(
"webserver", args.pid, args.stdout, args.stderr, args.log_file)
- os.environ.pop('SKIP_DAGS_PARSING')
Review comment:
Reverted the change and added a comment why it's there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r380105893
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -263,40 +264,31 @@ def monitor_gunicorn(gunicorn_master_proc):
sys.exit(gunicorn_master_proc.returncode)
if args.daemon:
- base, ext = os.path.splitext(pid)
- ctx = daemon.DaemonContext(
- pidfile=TimeoutPIDLockFile(base + "-monitor" + ext, -1),
- files_preserve=[handle],
- stdout=stdout,
- stderr=stderr,
- signal_map={
- signal.SIGINT: kill_proc,
- signal.SIGTERM: kill_proc
- },
Review comment:
Given these exist as properties of DaemonContext I would say we leave them ~there~here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r380105893
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -263,40 +264,31 @@ def monitor_gunicorn(gunicorn_master_proc):
sys.exit(gunicorn_master_proc.returncode)
if args.daemon:
- base, ext = os.path.splitext(pid)
- ctx = daemon.DaemonContext(
- pidfile=TimeoutPIDLockFile(base + "-monitor" + ext, -1),
- files_preserve=[handle],
- stdout=stdout,
- stderr=stderr,
- signal_map={
- signal.SIGINT: kill_proc,
- signal.SIGTERM: kill_proc
- },
Review comment:
Given these exist as properties of DaemonContext I would say we leave them there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7245: [AIRFLOW-6624] Improve
webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-601597919
This looks good to me as well @ashb -> is @turbaszek explanation enough for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `61.29%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
- Coverage 86.88% 86.56% -0.33%
==========================================
Files 924 924
Lines 44674 44681 +7
==========================================
- Hits 38816 38677 -139
- Misses 5858 6004 +146
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `58.50% <36.84%> (+2.58%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `79.09% <100.00%> (+2.56%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [9ad1844...cb0ad0c](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `61.29%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
- Coverage 86.88% 86.56% -0.33%
==========================================
Files 924 924
Lines 44674 44681 +7
==========================================
- Hits 38816 38677 -139
- Misses 5858 6004 +146
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `58.50% <36.84%> (+2.58%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `79.09% <100.00%> (+2.56%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [9ad1844...cb0ad0c](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7245: [AIRFLOW-6624]
Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/af91d9f4f08a6bf308cb10418669d17d1ae6cc44?src=pr&el=desc) will **decrease** coverage by `52.79%`.
> The diff coverage is `20.58%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
- Coverage 85.34% 32.54% -52.8%
==========================================
Files 791 790 -1
Lines 40128 40125 -3
==========================================
- Hits 34247 13059 -21188
- Misses 5881 27066 +21185
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `15.49% <15%> (-39.85%)` | :arrow_down: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `32.14% <28.57%> (-67.86%)` | :arrow_down: |
| [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...flow/contrib/example\_dags/example\_qubole\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX3F1Ym9sZV9zZW5zb3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [...ample\_dags/example\_emr\_job\_flow\_automatic\_steps.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2Vtcl9qb2JfZmxvd19hdXRvbWF0aWNfc3RlcHMucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [...contrib/example\_dags/example\_papermill\_operator.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX3BhcGVybWlsbF9vcGVyYXRvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| ... and [649 more](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [af91d9f...d44accd](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek merged pull request #7245: [AIRFLOW-6624]
Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7245:
[AIRFLOW-6624] Improve webserver command with pidfile checking
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7245: [AIRFLOW-6624] Improve webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#issuecomment-577833662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=h1) Report
> Merging [#7245](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `61.29%`.
[](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
- Coverage 86.88% 86.56% -0.33%
==========================================
Files 924 924
Lines 44674 44681 +7
==========================================
- Hits 38816 38677 -139
- Misses 5858 6004 +146
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/webserver\_command.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvd2Vic2VydmVyX2NvbW1hbmQucHk=) | `58.50% <36.84%> (+2.58%)` | :arrow_up: |
| [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `79.09% <100.00%> (+2.56%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7245/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=footer). Last update [9ad1844...cb0ad0c](https://codecov.io/gh/apache/airflow/pull/7245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services