You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by danobi <gi...@git.apache.org> on 2015/06/19 01:48:48 UTC
[GitHub] trafficserver pull request: TS-2978 Reorder member variables in Ht...
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/231
TS-2978 Reorder member variables in HttpSM State
Reduce padding by grouping non four byte aligned variables together.
Packing was done by hand, and pretty much only touched bools and chars. There was no attempt to pack any structs/objects.
Testing with sizeof()s showed a reduction in the size of HttpTransact::State from 4088B to 4064B.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-2978
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit 3b03c58843b53ba11aa2317e2ff11febe01d57bc
Author: Daniel Xu <da...@yahoo-inc.com>
Date: 2015-06-18T07:51:45Z
TS-2978 Reorder member variables in HttpSM State
Reduce padding by grouping non four byte aligned
variables together.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2978 Reorder member variables in Ht...
Posted by danobi <gi...@git.apache.org>.
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/231#issuecomment-113644090
Packed a little more. Now down to 4056B.
pahole results [here](http://pastebin.com/rutZmEN7)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2978 Reorder member variables in Ht...
Posted by danobi <gi...@git.apache.org>.
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/231#issuecomment-113320662
Further testing with pahole may be done later, when I get a vm setup with a supported OS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2978 Reorder member variables in Ht...
Posted by danobi <gi...@git.apache.org>.
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2978 Reorder member variables in Ht...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/231#issuecomment-113320883
Can you show the pahole(1) results for before and after?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2978 Reorder member variables in Ht...
Posted by danobi <gi...@git.apache.org>.
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/231#issuecomment-113575571
pahole results for [unpacked](http://pastebin.com/WwLFSrrG)
pahole results for [packed](http://pastebin.com/Cr6jtZac)
Although it looks like there's another 200B we can squeeze out, I'm not sure if scrambling up all the variable groupings is worth it.
I'll spend some more time trying to get some free bytes today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---