You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/07/11 10:26:19 UTC
[GitHub] flink pull request #6304: [FLINK-9801][build] Add missing example dependenci...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6304
[FLINK-9801][build] Add missing example dependencies to flink-dist
## What is the purpose of the change
With this PR `flink-dist` explicitly depends on `flink-examples-batch` and `flink-examples-streaming`, to ensure that both modules are built
a) before flink-dist
b) when compiling flink-dist with the `-am` flag.
## Brief change log
* add dependencies to both modules
* add exclusions to shade-plugin so they aren't included in the `flink-dist` jar
## Verifying this change
Manually verified.
a) run `mvn validate -pl flink-dist -am` and check that both example modules are in the reactor build before flink-dist
b) compile flink-dist and check that code from neither module is present in flink-dist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9801
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6304
----
commit d330a2587035491b98460e7686bdb0b036182de4
Author: zentol <ch...@...>
Date: 2018-07-11T10:23:24Z
[FLINK-9801][build] Add missing example dependencies to flink-dist
----
---
[GitHub] flink issue #6304: [FLINK-9801][build] Add missing example dependencies to f...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/6304
LGTM
---
[GitHub] flink issue #6304: [FLINK-9801][build] Add missing example dependencies to f...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6304
merging.
---
[GitHub] flink issue #6304: [FLINK-9801][build] Add missing example dependencies to f...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6304
ah of course, we promote transitive dependencies in flink-dist, and the examples depend on kafka........................
---
[GitHub] flink pull request #6304: [FLINK-9801][build] Add missing example dependenci...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6304
---
[GitHub] flink issue #6304: [FLINK-9801][build] Add missing example dependencies to f...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6304
hm, so this causes fairly consistently timeouts in the kafka end-to-end test. How in the world can this break things...
---
[GitHub] flink pull request #6304: [FLINK-9801][build] Add missing example dependenci...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/6304#discussion_r201937327
--- Diff: flink-dist/pom.xml ---
@@ -140,6 +140,22 @@ under the License.
</exclusions>
</dependency>
+ <dependency>
--- End diff --
There is a section further down on the POM, with a comment "dependencies for "/examples" in scope provided. How about moving these entries there, then we get comments for "why it is like that" for free...
---
[GitHub] flink pull request #6304: [FLINK-9801][build] Add missing example dependenci...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6304#discussion_r202052321
--- Diff: flink-dist/pom.xml ---
@@ -140,6 +140,22 @@ under the License.
</exclusions>
</dependency>
+ <dependency>
--- End diff --
sure, will move while merging!
---